Git development
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: git@vger.kernel.org, gitster@pobox.com
Subject: [PATCH] remote show: Clean up connection correctly if object fetch wasn't done
Date: Sun, 2 Mar 2008 05:31:59 +0000 (GMT)	[thread overview]
Message-ID: <alpine.LSU.1.00.0803020531310.22527@racer.site> (raw)


Like in ls-remote, we have to disconnect the transport after getting
the remote refs.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---

	I did not make the connection when commenting on ls-remote, that
	builtin-remote uses the same API...

 builtin-remote.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/builtin-remote.c b/builtin-remote.c
index 2ad1a8d..2405c2c 100644
--- a/builtin-remote.c
+++ b/builtin-remote.c
@@ -387,6 +387,7 @@ static int show_or_prune(int argc, const char **argv, int prune)
 		transport = transport_get(NULL, states.remote->url_nr > 0 ?
 			states.remote->url[0] : NULL);
 		ref = transport_get_remote_refs(transport);
+		transport_disconnect(transport);
 
 		read_branches();
 		got_states = get_ref_states(ref, &states);
-- 
1.5.4.3.446.gbe8932


                 reply	other threads:[~2008-03-02  5:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.1.00.0803020531310.22527@racer.site \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox