Re: [PATCH 11/11] Support bundles in builtin-clone

[Johannes Schindelin <Johannes.Schindelin@gmx.de>]

Hi,

On Sun, 9 Mar 2008, Daniel Barkalow wrote:

> On Sun, 9 Mar 2008, Johannes Schindelin wrote:
> 
> > On Sat, 8 Mar 2008, Johannes Schindelin wrote:
> > 
> > > This forward-ports c6fef0bb(clone: support cloning full bundles) to 
> > > the builtin clone.
> > > 
> > > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > > ---
> > 
> > Wow... Is this a new send-email feature?  I did not send this email...
> 
> Nope, it's an old format-patch feature. format-patch generates the 
> messages with the From: being the commit author, and my MTA doesn't 
> complain about the fact that I'm sending email with some entirely 
> different From:. It would probably be more clever to have format-patch 
> use the committer or the current user as the From:, and put an 
> additional From: in the message body with the author if it's not the 
> email From:.

I think that makes sense.

> Of course, you did sort of send that email 
> (http://permalink.gmane.org/gmane.comp.version-control.git/75743).

Sort of.

Of course, I am okay with it, but I consider the From: issue a real bug in 
send-email (or format-patch, if you want).

Ciao,
Dscho