Git development
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] builtin-clone: fix for new unpack_trees() semantics
Date: Mon, 10 Mar 2008 11:58:50 +0100 (CET)	[thread overview]
Message-ID: <alpine.LSU.1.00.0803101157300.3975@racer.site> (raw)
In-Reply-To: <alpine.LNX.1.00.0803091911010.19665@iabervon.org>

Hi,

On Sun, 9 Mar 2008, Daniel Barkalow wrote:

> On Mon, 10 Mar 2008, Johannes Schindelin wrote:
> 
> > Yes.  And this sets dst_index (what I tried to hint at with my patch).
> 
> Oh, yes. Your patch is what prompted me to fix that part (and to find 
> that Linus's unpack_trees was in next now). But seeing src_index in your 
> patch made me wonder what it wanted a source index for anyway, since 
> this is the first index we've had in this repo.

Well, stupid copy-'n-paste.  Well, not all that stupid: because of the 
twoway_merge (and because the segmentation fault was in a line accessing 
src_index), I assumed that the src_index is needed.

But your explanation that oneway_merge is all we want makes tons of sense.

Ciao,
Dscho

      reply	other threads:[~2008-03-10 10:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-08 23:04 [PATCH 10/11] Build in clone Daniel Barkalow
2008-03-09 21:30 ` [PATCH] builtin-clone: fix for new unpack_trees() semantics Johannes Schindelin
2008-03-09 22:35   ` Daniel Barkalow
2008-03-09 22:55     ` Johannes Schindelin
2008-03-09 23:02       ` Daniel Barkalow
2008-03-09 23:05         ` Johannes Schindelin
2008-03-09 23:14           ` Daniel Barkalow
2008-03-10 10:58             ` Johannes Schindelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.1.00.0803101157300.3975@racer.site \
    --to=johannes.schindelin@gmx.de \
    --cc=barkalow@iabervon.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox