Git development
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH] sequencer: remove unnecessary variable setting
Date: Thu, 13 Aug 2026 09:44:14 +0200	[thread overview]
Message-ID: <an11zsTm-fanH8yt@pks.im> (raw)
In-Reply-To: <pull.1922.git.1786516959130.gitgitgadget@gmail.com>

On Wed, Aug 12, 2026 at 06:42:38AM +0000, Elijah Newren via GitGitGadget wrote:
> diff --git a/sequencer.c b/sequencer.c
> index 83c3849205..a0abcc69ce 100644
> --- a/sequencer.c
> +++ b/sequencer.c
> @@ -6277,7 +6277,6 @@ int sequencer_make_script(struct repository *r, struct strbuf *out,
>  	revs.sort_order = REV_SORT_IN_GRAPH_ORDER;
>  	revs.topo_order = 1;
>  
> -	revs.pretty_given = 1;
>  	repo_config_get_string(the_repository, "rebase.instructionFormat", &format);
>  	if (!format || !*format) {
>  		free(format);

Makes sense. The only reference to this field is indeed in
"builtin/log.c", and as we don't use the sequencer there shouldn't be
any kind of interaction between those two subsystems here.

Thanks!

Patrick

      parent reply	other threads:[~2026-08-13  7:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-12  6:42 [PATCH] sequencer: remove unnecessary variable setting Elijah Newren via GitGitGadget
2026-08-12 17:24 ` Junio C Hamano
2026-08-13  7:44 ` Patrick Steinhardt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=an11zsTm-fanH8yt@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox