Git development
 help / color / mirror / Atom feed
From: Taylor Blau <ttaylorr@openai.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: "Taylor Blau" <me@ttaylorr.com>,
	git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
	"Jeff King" <peff@peff.net>, "Elijah Newren" <newren@gmail.com>,
	"SZEDER Gábor" <szeder.dev@gmail.com>
Subject: Re: [PATCH 1/3] t5334: expose shared `nth_line()` helper
Date: Thu, 13 Aug 2026 14:28:58 -0500	[thread overview]
Message-ID: <an4a-t0auyMFzbgS@com-79390> (raw)
In-Reply-To: <an2E6OV1Fr7wKFhn@pks.im>

On Thu, Aug 13, 2026 at 10:48:49AM +0200, Patrick Steinhardt wrote:
> On Fri, Jun 12, 2026 at 04:07:08PM -0400, Taylor Blau wrote:
> > diff --git a/t/lib-midx.sh b/t/lib-midx.sh
> > index e38c609604c..b522dbdb0f4 100644
> > --- a/t/lib-midx.sh
> > +++ b/t/lib-midx.sh
> > @@ -34,3 +34,9 @@ compare_results_with_midx () {
> >  		midx_git_two_modes "cat-file --batch-all-objects --batch-check --unordered" sorted
> >  	'
> >  }
> > +
> > +nth_line() {
> > +	local n="$1"
> > +	shift
> > +	awk "NR==$n" "$@"
> > +}
>
> It feels a bit weird to have such a general function in "lib-midx.sh",
> but so be it.

Yeah, I agree. It mostly just felt weird to write '| awk "NR==$n"' a
bunch of times.

Thanks,
Taylor

  reply	other threads:[~2026-08-13 19:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-12 20:07 [PATCH 0/3] midx: honor custom bases for incremental writes Taylor Blau
2026-06-12 20:07 ` [PATCH 1/3] t5334: expose shared `nth_line()` helper Taylor Blau
2026-08-13  8:48   ` Patrick Steinhardt
2026-08-13 19:28     ` Taylor Blau [this message]
2026-06-12 20:07 ` [PATCH 2/3] midx: pass custom '--base' through incremental writes Taylor Blau
2026-08-13  8:49   ` Patrick Steinhardt
2026-08-13 20:30     ` Taylor Blau
2026-08-14  7:27       ` Patrick Steinhardt
2026-06-12 20:07 ` [PATCH 3/3] midx-write: include packs above custom incremental base Taylor Blau
2026-08-13  8:49   ` Patrick Steinhardt
2026-08-13 20:50     ` Taylor Blau
2026-08-26 21:37       ` Junio C Hamano
2026-08-26 23:38         ` Taylor Blau
2026-08-31  6:12           ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=an4a-t0auyMFzbgS@com-79390 \
    --to=ttaylorr@openai.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=me@ttaylorr.com \
    --cc=newren@gmail.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox