From: Patrick Steinhardt <ps@pks.im>
To: Stefan Haller <lists@haller-berlin.de>
Cc: git@vger.kernel.org, Derrick Stolee <stolee@gmail.com>,
Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH 1/8] t: fix races caused by background maintenance
Date: Mon, 10 Aug 2026 10:35:43 +0200 [thread overview]
Message-ID: <anmNX-WVohAyjEcc@pks.im> (raw)
In-Reply-To: <801031d7-f219-4410-a863-7410cff7952f@haller-berlin.de>
On Mon, Aug 10, 2026 at 09:37:01AM +0200, Stefan Haller wrote:
> On 10.08.26 07:20, Patrick Steinhardt wrote:
>
> > Git commands should just work with concurrent maintenance, and if they
> > don't then it's worth to have a deeper look at why it doesn't.
>
> That was my point; in lazygit's test suite I was getting errors when
> executing simple commands such as "create a bunch of files, git add,
> git commit". I had cases where the commit fails with
>
> error: invalid object 100644 50d5612... for 'file09.txt'
> error: Error building trees
That's a bug then that we ought to fix. Do you maybe have a reproducer
for this?
Also, which version of Git are you testing this with? We recently had an
issue with multiple concurrent git-maintenance(1) processes running at
the same time, which is something that shouldn't ever happen. That was
fixed already, but IIRC Git 2.54 was still prone to this race.
Patrick
next prev parent reply other threads:[~2026-08-10 8:35 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 10:15 [PATCH 0/8] builtin/maintenance: use "geometric" strategy by default Patrick Steinhardt
2026-02-20 10:15 ` [PATCH 1/8] t: fix races caused by background maintenance Patrick Steinhardt
2026-02-23 16:01 ` Justin Tobler
2026-08-10 4:43 ` Stefan Haller
2026-08-10 5:20 ` Patrick Steinhardt
2026-08-10 7:37 ` Stefan Haller
2026-08-10 8:35 ` Patrick Steinhardt [this message]
2026-08-10 10:45 ` Stefan Haller
2026-08-10 13:55 ` Patrick Steinhardt
2026-08-10 15:12 ` Stefan Haller
2026-02-20 10:15 ` [PATCH 2/8] t: disable maintenance where we verify object database structure Patrick Steinhardt
2026-02-23 16:07 ` Justin Tobler
2026-02-20 10:15 ` [PATCH 3/8] t34xx: don't expire reflogs where it matters Patrick Steinhardt
2026-02-23 0:48 ` Derrick Stolee
2026-02-23 16:15 ` Justin Tobler
2026-02-20 10:15 ` [PATCH 4/8] t5400: explicitly use "gc" strategy Patrick Steinhardt
2026-02-20 10:15 ` [PATCH 5/8] t5510: " Patrick Steinhardt
2026-02-20 10:15 ` [PATCH 6/8] t6500: " Patrick Steinhardt
2026-02-20 10:15 ` [PATCH 7/8] t7900: prepare for switch of the default strategy Patrick Steinhardt
2026-02-20 10:15 ` [PATCH 8/8] builtin/maintenance: use "geometric" strategy by default Patrick Steinhardt
2026-02-23 0:52 ` Derrick Stolee
2026-02-23 9:49 ` Patrick Steinhardt
2026-02-23 16:48 ` Justin Tobler
2026-02-24 8:15 ` Patrick Steinhardt
2026-02-23 0:53 ` [PATCH 0/8] " Derrick Stolee
2026-02-24 8:45 ` [PATCH v2 " Patrick Steinhardt
2026-02-24 8:45 ` [PATCH v2 1/8] t: fix races caused by background maintenance Patrick Steinhardt
2026-02-24 8:45 ` [PATCH v2 2/8] t: disable maintenance where we verify object database structure Patrick Steinhardt
2026-02-24 8:45 ` [PATCH v2 3/8] t34xx: don't expire reflogs where it matters Patrick Steinhardt
2026-02-24 8:45 ` [PATCH v2 4/8] t5400: explicitly use "gc" strategy Patrick Steinhardt
2026-02-24 8:45 ` [PATCH v2 5/8] t5510: " Patrick Steinhardt
2026-02-24 8:45 ` [PATCH v2 6/8] t6500: " Patrick Steinhardt
2026-02-25 10:13 ` Toon Claes
2026-02-24 8:45 ` [PATCH v2 7/8] t7900: prepare for switch of the default strategy Patrick Steinhardt
2026-02-24 8:45 ` [PATCH v2 8/8] builtin/maintenance: use "geometric" strategy by default Patrick Steinhardt
2026-02-24 12:12 ` Derrick Stolee
2026-02-25 10:33 ` Toon Claes
2026-02-24 18:54 ` [PATCH v2 0/8] " Justin Tobler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anmNX-WVohAyjEcc@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=lists@haller-berlin.de \
--cc=me@ttaylorr.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox