Git development
 help / color / mirror / Atom feed
From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Peter Morris <mrpmorris@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC] git worktree: use filesystem cloning where supported
Date: Sat, 15 Aug 2026 14:33:09 +0000	[thread overview]
Message-ID: <aoB4pOTtJ65PjwPA@fruit.crustytoothpaste.net> (raw)
In-Reply-To: <CAOqWQb+XY_u2OUNnBJ9GBGBz8B73ocHWp+V1tDBS-4a5-OviYA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 841 bytes --]

On 2026-08-14 at 13:29:26, Peter Morris wrote:
> The PR says it only supports Linux and macOS, but ReFS
> is available on Windows too.
> 
> I believe that if the source and destination are on the same ReFS
> volume the Windows CopyFile API will use block cloning automatically,
> so if CopyFile were used we would get this for free on Windows Dev
> Drives.

ReFS has serious defects in its implementation.  If the data has been
written but not flushed to disk, the resulting copy will be corrupt.  I
just saw this come in with Git LFS[0] and I described it to a colleague
as "horribly broken".  I definitely don't recommend adding support for
this to Git until only fixed versions of Windows are publicly available.

[0] https://github.com/git-lfs/git-lfs/issues/6312
-- 
brian m. carlson (they/them)
Toronto, Ontario, CA

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 325 bytes --]

  reply	other threads:[~2026-08-15 14:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-14 10:40 [RFC] git worktree: use filesystem cloning where supported Peter Morris
2026-08-14 10:54 ` Kristoffer Haugsbakk
     [not found]   ` <CAOqWQbLEakpQEPsfw-GB70fdwbxW8EcdZ8EWzaN6ZAaHUU+jGQ@mail.gmail.com>
2026-08-14 11:34     ` Kristoffer Haugsbakk
     [not found]   ` <CAOqWQb+YzvVeqS85qYjQKK8jrUqDwV01eKqC8i1jgT886ixCwA@mail.gmail.com>
2026-08-14 13:29     ` Peter Morris
2026-08-15 14:33       ` brian m. carlson [this message]
2026-08-15 18:09         ` Peter Morris
2026-08-14 16:29   ` Junio C Hamano
2026-08-15 18:03     ` Peter Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoB4pOTtJ65PjwPA@fruit.crustytoothpaste.net \
    --to=sandals@crustytoothpaste.net \
    --cc=git@vger.kernel.org \
    --cc=mrpmorris@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox