Git development
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Justin Tobler <jltobler@gmail.com>
Subject: Re: [PATCH v2 1/4] odb: decouple source path comparisons from `the_repository`
Date: Mon, 17 Aug 2026 07:36:50 +0200	[thread overview]
Message-ID: <aoKd8g43J6k0xaKN@pks.im> (raw)
In-Reply-To: <20260814172113.GC2563235@coredump.intra.peff.net>

On Fri, Aug 14, 2026 at 01:21:13PM -0400, Jeff King wrote:
> On Wed, Aug 12, 2026 at 11:13:57AM +0200, Patrick Steinhardt wrote:
> 
> > Fix this by making the comparison self-contained in the object
> > database. Instead of using `fspathhash()` and `fspatheq()` we resolve
> > "core.ignoreCase" manually and then use the correct comparison function
> > based on the result. This requires us to migrate to a `struct hashmap`,
> > as the khash interface does not give us the ability to change these
> > functions.
> 
> By the way, this bit about khash confused me. We can provide whatever
> hash and equality functions we want. But I'm guessing maybe the issue is
> that in the khash function interface khash expects, there's no extra
> "void *" parameter you can use to store the bit to tell you whether to
> be case insensitive or not?

Ah, yes, that's in fact what I wanted to convey. I'll clarify that a
bit.

Patrick

  reply	other threads:[~2026-08-17  5:36 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10 13:33 [PATCH 0/4] odb: eagerly load alternates Patrick Steinhardt
2026-08-10 13:33 ` [PATCH 1/4] odb: decouple source path comparisons from `the_repository` Patrick Steinhardt
2026-08-11 22:04   ` Justin Tobler
2026-08-12  5:39     ` Patrick Steinhardt
2026-08-10 13:33 ` [PATCH 2/4] odb: eagerly initialize alternates Patrick Steinhardt
2026-08-11 22:15   ` Justin Tobler
2026-08-12  5:39     ` Patrick Steinhardt
2026-08-10 13:33 ` [PATCH 3/4] odb: drop `loaded_alternates` field Patrick Steinhardt
2026-08-11 22:22   ` Justin Tobler
2026-08-10 13:33 ` [PATCH 4/4] odb: drop `alternates_db` field Patrick Steinhardt
2026-08-11 22:31   ` Justin Tobler
2026-08-12  5:39     ` Patrick Steinhardt
2026-08-12  9:13 ` [PATCH v2 0/4] odb: eagerly load alternates Patrick Steinhardt
2026-08-12  9:13   ` [PATCH v2 1/4] odb: decouple source path comparisons from `the_repository` Patrick Steinhardt
2026-08-13 12:23     ` Karthik Nayak
2026-08-13 13:17       ` Patrick Steinhardt
2026-08-14 10:21         ` Karthik Nayak
2026-08-14 17:17     ` Jeff King
2026-08-14 19:03       ` Junio C Hamano
2026-08-14 20:36         ` Jeff King
2026-08-17  5:39       ` Patrick Steinhardt
2026-08-17  7:16         ` Patrick Steinhardt
2026-08-17  7:36           ` Jeff King
2026-08-17  9:42             ` Patrick Steinhardt
2026-08-17 17:47               ` Jeff King
2026-08-17  7:28         ` Jeff King
2026-08-14 17:21     ` Jeff King
2026-08-17  5:36       ` Patrick Steinhardt [this message]
2026-08-12  9:13   ` [PATCH v2 2/4] odb: eagerly initialize alternates Patrick Steinhardt
2026-08-12  9:13   ` [PATCH v2 3/4] odb: drop `loaded_alternates` field Patrick Steinhardt
2026-08-13 12:25     ` Karthik Nayak
2026-08-12  9:14   ` [PATCH v2 4/4] odb: drop `alternates_db` field Patrick Steinhardt
2026-08-12 15:38   ` [PATCH v2 0/4] odb: eagerly load alternates Junio C Hamano
2026-08-13  8:56     ` Patrick Steinhardt
2026-08-13 12:28   ` Karthik Nayak
2026-08-13 17:09   ` Justin Tobler
2026-08-17 11:09 ` [PATCH v3 0/5] " Patrick Steinhardt
2026-08-17 11:09   ` [PATCH v3 1/5] setup: create ref and object databases after config is written Patrick Steinhardt
2026-08-17 11:09   ` [PATCH v3 2/5] odb: decouple source path comparisons from `the_repository` Patrick Steinhardt
2026-08-17 11:09   ` [PATCH v3 3/5] odb: eagerly initialize alternates Patrick Steinhardt
2026-08-17 11:09   ` [PATCH v3 4/5] odb: drop `loaded_alternates` field Patrick Steinhardt
2026-08-17 11:09   ` [PATCH v3 5/5] odb: drop `alternates_db` field Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoKd8g43J6k0xaKN@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=jltobler@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox