Re: [PATCH 04/10] builtin/fsck: don't check alternates with "--no-full"

[Patrick Steinhardt <ps@pks.im>]

On Thu, Aug 27, 2026 at 06:12:13AM -0400, Karthik Nayak wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > According to git-fsck(1), the "--full" option behaves in the following
> > way:
> >
> >   Check not just objects in GIT_OBJECT_DIRECTORY ($GIT_DIR/objects), but
> >   also the ones found in alternate object pools listed in
> >   GIT_ALTERNATE_OBJECT_DIRECTORIES or $GIT_DIR/objects/info/alternates,
> >   and in packed Git archives found in $GIT_DIR/objects/pack and
> >   corresponding pack subdirectories in alternate object pools.
> >
> > So ultimately, it is supposed to control two things: (1) whether we only
> > check the main object directory, and (2) whether we check packfiles.
> >
> > In its current state though, the flag only controls whether we check
> > packfiles or not, and if so we verify packfiles of all attached sources.
> > But we also have checks for loose objects in git-fsck(1), and here we
> > unconditionally check them in all sources.
> >
> 
> To reiterate,
> 
> without '--full': Check local loose + alternate loose. No packed objects
> 
> with '--full': Check local loose + alternate loose. local packed +
> alternates packed.
> 
> And we want to only do local loose in the latter. Makes sense.

s/latter/former/, but other than this: yes.

Patrick