From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] repository: make repo_clear() idempotent
Date: Thu, 3 Sep 2026 07:15:39 +0200 [thread overview]
Message-ID: <apkCe9CKvYvM6Hy9@pks.im> (raw)
In-Reply-To: <xmqqpkyvk45f.fsf@gitster.g>
On Wed, Sep 02, 2026 at 09:29:48AM -0700, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
>
> > I was at one point wondering whether the parsed object pool should
> > really be an implementation detail of the object database -- parsing
> > objects should not have to depend on the repository, ...
>
> We need to be a bit careful here, as the above directly contradicts
> our earlier design choice to have things like hash algorithm as
> properties of a repository instance.
Yeah, true. The question though is whether it really makes sense to
always propagate down the full repository, or whether we should instead
propagate only what matters. We do of course require the hash algorithm
(and potentially the compatibility hash algorithm) in these subsystems,
but propagating these two pieces of information might be the saner
approach compared to always making the full repository available.
In any case, I eventually discarded the above idea anyway.
Patrick
next prev parent reply other threads:[~2026-09-03 5:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 5:51 [PATCH 0/2] fix a leak in submodule error path Jeff King
2026-09-02 5:55 ` [PATCH 1/2] repository: make repo_clear() idempotent Jeff King
2026-09-02 6:29 ` Jeff King
2026-09-02 6:49 ` Jeff King
2026-09-02 9:11 ` Patrick Steinhardt
2026-09-02 16:29 ` Junio C Hamano
2026-09-03 5:15 ` Patrick Steinhardt [this message]
2026-09-02 5:57 ` [PATCH 2/2] submodule--helper: free URL when repository setup fails Jeff King
2026-09-02 9:11 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apkCe9CKvYvM6Hy9@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox