From: Patrick Steinhardt <ps@pks.im>
To: Souma <git@5ouma.me>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH v2 1/2] replay: allow callers to sign commits
Date: Fri, 11 Sep 2026 09:57:49 +0200 [thread overview]
Message-ID: <aqO0fcF-feQHIjks@pks.im> (raw)
In-Reply-To: <20260717145142.39478-2-git@5ouma.me>
On Fri, Jul 17, 2026 at 02:51:41PM +0000, Souma wrote:
Sorry for taking so long to review this, I lost track of this series.
> The replay machinery creates commits directly through
> `commit_tree_extended()`, but callers cannot currently request
> signatures. Commands that replay rewritten history consequently cannot
> carry their signing policy through to descendant commits.
>
> Add `sign_commit` to `replay_revisions_options` and thread it through
> commit creation. `NULL` preserves the existing unsigned behavior, an
> empty string selects the default signing key, and a non-empty string
> selects an explicit key. Existing callers zero-initialize the options
> structure, so their behavior is unchanged.
Nit: I feel like documenting the exact behaviour of that parameter here
is a bit excessive. You document it in-code, which is sufficient.
The changes themselves look good to me.
Patrick
next prev parent reply other threads:[~2026-09-11 7:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 14:50 [PATCH 0/3] history: sign rewritten commits Souma
2026-07-03 14:50 ` [PATCH 1/3] builtin/history: " Souma
2026-07-16 10:18 ` Patrick Steinhardt
2026-07-03 14:50 ` [PATCH 2/3] doc: document history signing options Souma
2026-07-16 10:18 ` Patrick Steinhardt
2026-07-03 14:50 ` [PATCH 3/3] t345x: cover signed history rewrites Souma
2026-07-17 14:51 ` [PATCH v2 0/2] history: support signing rewritten commits Souma
2026-07-17 14:51 ` [PATCH v2 1/2] replay: allow callers to sign commits Souma
2026-09-11 7:57 ` Patrick Steinhardt [this message]
2026-07-17 14:51 ` [PATCH v2 2/2] builtin/history: sign rewritten commits Souma
2026-09-11 7:57 ` Patrick Steinhardt
2026-09-12 16:00 ` [PATCH v3 0/2] history: support signing " Souma
2026-09-12 16:00 ` [PATCH v3 1/2] replay: allow callers to sign commits Souma
2026-09-12 16:00 ` [PATCH v3 2/2] history: sign rewritten commits Souma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqO0fcF-feQHIjks@pks.im \
--to=ps@pks.im \
--cc=git@5ouma.me \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox