Git development
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Kazumasa Shigeta <kazumasa.shigeta@kanamei.com>
Cc: git@vger.kernel.org,
	Shabbir Bhojani <shabbir.r.bhojani@gmail.com>,
	Phillip Wood <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH v2] stash: expose untracked modes in create
Date: Thu, 1 Oct 2026 13:32:19 +0200	[thread overview]
Message-ID: <ar5EwwEt8-ADeLdr@pks.im> (raw)
In-Reply-To: <20261001042155.33303-1-kazumasa.shigeta@kanamei.com>

On Thu, Oct 01, 2026 at 01:21:55PM +0900, Kazumasa Shigeta wrote:

When sending a v2 in response to review feedback it's a good idea to
both:

  - Respond to the reviewer to acknowledge their feedback and/or engage
    in a discussion.

  - As part of v2, send a range-diff as well as some documentation what
    has changed between the two versions.

This ensures some netiquette in an age where we're increasingly only
talking with AI, either directly or via a meat proxy. And makes it
easier for the reviewer to see how exactly you have honored their
feedback.

Thanks!

Patrick

  reply	other threads:[~2026-10-01 11:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29  7:42 [PATCH] stash: expose untracked modes in create Kazumasa Shigeta
2026-09-29 16:08 ` Phillip Wood
2026-10-01 17:44   ` 重田一聖
2026-10-05 16:37     ` Phillip Wood
2026-10-01  4:21 ` [PATCH v2] " Kazumasa Shigeta
2026-10-01 11:32   ` Patrick Steinhardt [this message]
2026-10-01 16:01     ` 重田一聖
2026-10-01 16:36     ` Junio C Hamano
2026-10-01 17:03   ` Junio C Hamano
2026-10-02  1:53     ` 重田一聖
2026-10-02  9:04     ` 重田一聖
2026-10-05  5:55       ` 重田一聖
2026-10-05 16:38         ` Phillip Wood
2026-10-06  9:25           ` 重田一聖
2026-10-06  9:57             ` Phillip Wood
2026-10-08  3:43               ` 重田一聖
2026-10-05 16:43         ` Junio C Hamano
2026-10-08 13:58           ` 重田一聖
2026-10-09 19:05             ` Junio C Hamano
2026-10-10  6:34               ` 重田一聖

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ar5EwwEt8-ADeLdr@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=kazumasa.shigeta@kanamei.com \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=shabbir.r.bhojani@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox