Git development
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Justin Tobler <jltobler@gmail.com>
Cc: git@vger.kernel.org, karthik.188@gmail.com
Subject: Re: [PATCH v2 1/2] object-file: lift ODB reprepare out of packfile flush
Date: Thu, 24 Sep 2026 08:13:37 +0200	[thread overview]
Message-ID: <arS_kcMcgrjfT9KE@pks.im> (raw)
In-Reply-To: <20260923220315.569424-2-jltobler@gmail.com>

On Wed, Sep 23, 2026 at 05:03:14PM -0500, Justin Tobler wrote:
> When flushing a packfile via `flush_packfile_transaction()`,
> `odb_reprepare()` is invoked so the written packfile becomes visible in
> the current process. In a subsequent commit, flushing the packfile is
> performed earlier when committing a "files" ODB transaction, but the ODB
> reprepare needs to remain the last step.

Yup, this is more in line with what that second commit will do.

Patrick

  reply	other threads:[~2026-09-24  6:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-13 20:26 [PATCH 0/2] object-file: fix packfile flush during transaction commit Justin Tobler
2026-09-13 20:26 ` [PATCH 1/2] object-file: lift ODB reprepare out of packfile flush Justin Tobler
2026-09-15  4:40   ` Karthik Nayak
2026-09-15  8:54     ` Justin Tobler
2026-09-23 13:16   ` Patrick Steinhardt
2026-09-23 21:04     ` Justin Tobler
2026-09-24  5:58       ` Patrick Steinhardt
2026-09-24  6:00         ` Patrick Steinhardt
2026-09-13 20:26 ` [PATCH 2/2] object-file: flush transaction packfile before migrating objects Justin Tobler
2026-09-15  4:46   ` Karthik Nayak
2026-09-15  8:59     ` Justin Tobler
2026-09-23 13:16   ` Patrick Steinhardt
2026-09-23 21:17     ` Justin Tobler
2026-09-23 22:03 ` [PATCH v2 0/2] object-file: fix packfile flush during transaction commit Justin Tobler
2026-09-23 22:03   ` [PATCH v2 1/2] object-file: lift ODB reprepare out of packfile flush Justin Tobler
2026-09-24  6:13     ` Patrick Steinhardt [this message]
2026-09-23 22:03   ` [PATCH v2 2/2] object-file: flush transaction packfile before migrating objects Justin Tobler
2026-09-24  6:01   ` [PATCH v2 0/2] object-file: fix packfile flush during transaction commit Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arS_kcMcgrjfT9KE@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=jltobler@gmail.com \
    --cc=karthik.188@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox