From: Patrick Steinhardt <ps@pks.im>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] ci: fix unit tests not running on windows
Date: Thu, 24 Sep 2026 16:14:02 +0200 [thread overview]
Message-ID: <arUwKpju14AVHOIy@pks.im> (raw)
In-Reply-To: <20260924-785-unit-tests-don-t-run-on-windows-v1-1-223cd2e4df43@gmail.com>
On Thu, Sep 24, 2026 at 03:09:18PM +0200, Karthik Nayak wrote:
> Since 3141df7ec4 (ci: don't skip smallest test slice in GitLab,
> 2026-02-19) both our CI workflows at GitLab and GitHub use one-indexed
> slices to run windows tests. Modify the check for running unit tests on
> Windows to also be one-indexed as otherwise, the unit tests are never
> run.
Oh, that's something that I missed indeed. At least we've still been
running unit tests via Meson :)
> diff --git a/ci/run-test-slice.sh b/ci/run-test-slice.sh
> index ff948e397f..d0063efc42 100755
> --- a/ci/run-test-slice.sh
> +++ b/ci/run-test-slice.sh
> @@ -10,8 +10,8 @@ TESTS=$(cd t && ./helper/test-tool path-utils slice-tests "$1" "$2" t[0-9]*.sh)
> group "Run tests" make --quiet -C t T="$(echo "$TESTS" | tr '\n' ' ')" ||
> handle_failed_tests
>
> -# We only have one unit test at the moment, so run it in the first slice
> -if [ "$1" == "0" ] ; then
> +# We only have one unit test at the moment, so run it in the first slice.
> +if [ "$1" == "1" ] ; then
> group "Run unit tests" make --quiet -C t unit-tests-test-tool
> fi
The diff looks good to me, thanks!
Patrick
prev parent reply other threads:[~2026-09-24 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 13:09 [PATCH] ci: fix unit tests not running on windows Karthik Nayak
2026-09-24 14:14 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arUwKpju14AVHOIy@pks.im \
--to=ps@pks.im \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox