From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: jyotish kumar <jyotishkumar725015@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] name-rev: update hash descriptions
Date: Sun, 27 Sep 2026 22:34:03 +0000 [thread overview]
Message-ID: <armZ28MWl9dTHDz6@fruit.crustytoothpaste.net> (raw)
In-Reply-To: <20260927194602.86750-1-jyotishkumar725015@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1680 bytes --]
On 2026-09-27 at 19:46:02, jyotish kumar wrote:
> The documentation for --annotate-stdin and --name-only refers to
> SHA-1, although name-rev handles object IDs according to the active
> hash algorithm.
>
> Update the descriptions to refer to object IDs instead.
>
> Signed-off-by: jyotish kumar <jyotishkumar725015@gmail.com>
> ---
> Documentation/git-name-rev.adoc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/git-name-rev.adoc b/Documentation/git-name-rev.adoc
> index d4f1c4d594..9837fe59b3 100644
> --- a/Documentation/git-name-rev.adoc
> +++ b/Documentation/git-name-rev.adoc
> @@ -43,7 +43,7 @@ OPTIONS
> List all commits reachable from all refs
>
> --annotate-stdin::
> - Transform stdin by substituting all the 40-character SHA-1
> + Transform stdin by substituting all the full-length object ID
> hexes (say $hex) with "$hex ($rev_name)". When used with
> --name-only, substitute with "$rev_name", omitting $hex
> altogether. This option was called `--stdin` in older versions
> @@ -72,7 +72,7 @@ while its tree object is 70d105cc79e63b81cfdcb08a15297c23e60b07ad
> -----------
>
> --name-only::
> - Instead of printing both the SHA-1 and the name, print only
> + Instead of printing both the object ID and the name, print only
> the name. If given with --tags the usual tag prefix of
> "tags/" is also omitted from the name, matching the output
> of `git-describe` more closely.
This looks much better. I didn't see any other instances of "SHA-1" in
the documentation or "40", so this looks complete.
--
brian m. carlson (they/them)
Toronto, Ontario, CA
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 325 bytes --]
next prev parent reply other threads:[~2026-09-27 22:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 9:54 [DOC] name-rev: --annotate-stdin docs still describe SHA-1 jyotish kumar
2026-09-27 13:50 ` brian m. carlson
2026-09-27 19:46 ` [PATCH] name-rev: update hash descriptions jyotish kumar
2026-09-27 22:34 ` brian m. carlson [this message]
2026-09-27 22:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=armZ28MWl9dTHDz6@fruit.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=jyotishkumar725015@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox