Git development
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Patrick Monette <pmonette@google.com>
Cc: git@vger.kernel.org, newren@gmail.com, toon@iotcl.com
Subject: Re: [PATCH 0/2] replay: add signing support
Date: Mon, 28 Sep 2026 09:41:46 +0200	[thread overview]
Message-ID: <aroaOsUFWt2lYOVS@pks.im> (raw)
In-Reply-To: <20260925205348.1210154-1-pmonette@google.com>

Hi,

On Fri, Sep 25, 2026 at 04:53:46PM -0400, Patrick Monette wrote:
> This pair of commits fixes a FIXME in replay.c. With this, it's possible
> to sign commits using `git replay`.
> 
> To follow the convention of git plumbing commands, where they must
> behave the same regardless of user config, `commit.gpgSign` is
> intentionally ignored.
> 
> The first patch fixes pick_regular_commit() to ensure failures to create
> commits are correctly handled, which can now happen more easily because
> of signing.

Note that there's already a patch series in flight that's adding the
infra to sign commits at [1]. Your patches will conflict with that
series, even though you're ultimately adapting git-replay(1) and not
git-history(1). So I'd suggest that once the series at [1] land, you can
maybe rebase your changes and then send a new version.

Patrick

[1]: <20260912160045.36064-1-git@5ouma.me>

  parent reply	other threads:[~2026-09-28  7:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25 20:53 [PATCH 0/2] replay: add signing support Patrick Monette
2026-09-25 20:53 ` [PATCH 1/2] replay: handle failure to create commits Patrick Monette
2026-09-28  7:41   ` Patrick Steinhardt
2026-09-25 20:53 ` [PATCH 2/2] replay: add the -S option Patrick Monette
2026-09-28  7:41   ` Patrick Steinhardt
2026-10-02 21:23   ` Junio C Hamano
2026-09-28  7:41 ` Patrick Steinhardt [this message]
2026-09-28 15:23   ` [PATCH 0/2] replay: add signing support Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aroaOsUFWt2lYOVS@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    --cc=pmonette@google.com \
    --cc=toon@iotcl.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox