From: Patrick Steinhardt <ps@pks.im>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org, Josh McKinney <git-bugs@lists.joshka.net>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 3/3] refs/reftable: fix on-disk representation of reflog timezones
Date: Wed, 30 Sep 2026 14:05:33 +0200 [thread overview]
Message-ID: <arz7DV44Au08oLad@pks.im> (raw)
In-Reply-To: <CAOLa=ZQorPk_Kkewkw5k-gdeh=VRVBMcaDA54S0ByJfAswcCWQ@mail.gmail.com>
On Wed, Sep 30, 2026 at 04:51:15AM -0700, Karthik Nayak wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> > diff --git a/t/t0610-reftable-basics.sh b/t/t0610-reftable-basics.sh
> > index 35e98b43db..579657467d 100755
> > --- a/t/t0610-reftable-basics.sh
> > +++ b/t/t0610-reftable-basics.sh
> > @@ -837,6 +837,41 @@ test_expect_success 'reflog: renaming branch writes reflog entry' '
> > )
> > '
> >
> > +test_expect_success 'reflog: timezone offset is stored in minutes' '
> > + test_when_finished "rm -rf repo" &&
> > + git init repo &&
> > + (
> > + cd repo &&
> > + GIT_COMMITTER_DATE="1234567890 -1200" git commit --allow-empty -m min &&
> > + GIT_COMMITTER_DATE="1234567890 +0530" git commit --allow-empty -m east &&
> > + GIT_COMMITTER_DATE="1234567890 -0800" git commit --allow-empty -m west &&
> > + GIT_COMMITTER_DATE="1234567890 +1400" git commit --allow-empty -m max &&
>
> Nit: it would be nice to have a negative timezone with MM filled in too.
Sure, can do. I'll just change -0800 to -0830. Thanks!
Patrick
next prev parent reply other threads:[~2026-09-30 12:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 9:56 [PATCH 0/3] refs/reftable: fix on-disk representation of reflog timezones Patrick Steinhardt
2026-09-29 9:56 ` [PATCH 1/3] date: add helpers to convert between "+HHMM" timezones and minutes Patrick Steinhardt
2026-09-30 11:47 ` Karthik Nayak
2026-09-30 12:05 ` Patrick Steinhardt
2026-10-01 10:18 ` Karthik Nayak
2026-09-30 19:54 ` Junio C Hamano
2026-09-29 9:56 ` [PATCH 2/3] t/helper: fix segfault in "dump-reftable -t" Patrick Steinhardt
2026-09-29 9:56 ` [PATCH 3/3] refs/reftable: fix on-disk representation of reflog timezones Patrick Steinhardt
2026-09-30 11:51 ` Karthik Nayak
2026-09-30 12:05 ` Patrick Steinhardt [this message]
2026-10-01 5:38 ` [PATCH v2 0/3] " Patrick Steinhardt
2026-10-01 5:39 ` [PATCH v2 1/3] date: add helpers to convert between "+HHMM" timezones and minutes Patrick Steinhardt
2026-10-01 5:39 ` [PATCH v2 2/3] t/helper: fix segfault in "dump-reftable -t" Patrick Steinhardt
2026-10-01 5:39 ` [PATCH v2 3/3] refs/reftable: fix on-disk representation of reflog timezones Patrick Steinhardt
2026-10-01 10:19 ` [PATCH v2 0/3] " Karthik Nayak
2026-10-01 17:11 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arz7DV44Au08oLad@pks.im \
--to=ps@pks.im \
--cc=git-bugs@lists.joshka.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox