Re: [PATCH 1/4] libgitcore: add `sha1dc` as an optional feature

["brian m. carlson" <sandals@crustytoothpaste.net>]

[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]

On 2026-09-28 at 15:51:28, Johannes Schindelin via GitGitGadget wrote:
> Note that the `sha1dc` crate still requires a significantly newer Rust
> version than Git's existing Rust support requires: 1.87 instead of
> 1.63 (https://crates.io/api/v1/crates/sha1dc/0.1.3).

I think this is going to be a problem.  Yes, this is optional, but we
declare compatibility with Rust 1.49.0 in Cargo.toml and we want
everything to work there.

The goal was to have everything work with gccrs, but I think we're
nearing Git 3.0 and gccrs has not made enough progress for it to be
viable.  This is not a surprise to me, but that was our goal.

The approach I've been advocating is that we support the version in
Debian stable, plus the version in Debian oldstable for a year after the
new stable comes out.  That would get us to Rust 1.85.1, since Debian
13 (trixie) came out over a year ago, but not to Rust 1.87.

In any event, if we want to raise the version of Rust, we should
probably discuss that in a separate series that adds or updates a policy
document and bumps the version in Cargo.toml.
-- 
brian m. carlson (they/them)
Toronto, Ontario, CA

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 325 bytes --]