From: Patrick Steinhardt <ps@pks.im>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Toon Claes <toon@iotcl.com>
Subject: Re: [PATCH v4] packed-refs: use `fwrite()` when passing refs verbatim
Date: Wed, 7 Oct 2026 13:52:36 +0200 [thread overview]
Message-ID: <asYyhHB8DROQpkBB@pks.im> (raw)
In-Reply-To: <20261007-kn-speedup-packed-refs-v4-1-79a411026596@gmail.com>
On Wed, Oct 07, 2026 at 01:20:16PM +0200, Karthik Nayak wrote:
> Changes in v4:
> - Modify the commit message to state the issue with the previous
> approach.
> - Modify the comment for `record_start` to remove ambiguity around its
> setting.
> - Remove `write_packed_entry_raw()` and inline the call to `fwrite()`.
> - Link to v3: https://patch.msgid.link/20261006-kn-speedup-packed-refs-v3-1-a1c76b1df9e0@gmail.com
Thanks, I'm happy with this version.
Patrick
next prev parent reply other threads:[~2026-10-07 11:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 15:15 [PATCH] packed-refs: use `fwrite()` when passing refs verbatim Karthik Nayak
2026-10-01 20:30 ` Toon Claes
2026-10-02 0:16 ` Karthik Nayak
2026-10-02 13:03 ` [PATCH v2] " Karthik Nayak
2026-10-05 18:34 ` Toon Claes
2026-10-06 9:36 ` Karthik Nayak
2026-10-06 9:18 ` [PATCH v3] " Karthik Nayak
2026-10-06 12:31 ` Patrick Steinhardt
2026-10-06 21:11 ` Karthik Nayak
2026-10-07 5:12 ` Patrick Steinhardt
2026-10-07 9:25 ` Karthik Nayak
2026-10-06 16:19 ` Junio C Hamano
2026-10-06 20:59 ` Karthik Nayak
2026-10-07 11:20 ` [PATCH v4] " Karthik Nayak
2026-10-07 11:52 ` Patrick Steinhardt [this message]
2026-10-08 11:41 ` Toon Claes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asYyhHB8DROQpkBB@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karthik.188@gmail.com \
--cc=toon@iotcl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox