From: Patrick Steinhardt <ps@pks.im>
To: Harald Nordgren via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Harald Nordgren <haraldnordgren@gmail.com>
Subject: Re: [PATCH v3 2/2] ci: fail the build if perforce, git-lfs, or JGit fail to install
Date: Mon, 26 Oct 2026 12:08:18 +0100 [thread overview]
Message-ID: <at80okuHpoUjUYpQ@pks.im> (raw)
In-Reply-To: <a57cfbb2a5c0f34e44595c3b688b18c760258685.1793008465.git.gitgitgadget@gmail.com>
On Mon, Oct 26, 2026 at 09:54:25AM +0000, Harald Nordgren via GitGitGadget wrote:
> diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
> index 203e8401cf..7c3c6ad434 100755
> --- a/ci/install-dependencies.sh
> +++ b/ci/install-dependencies.sh
> @@ -94,22 +94,25 @@ ubuntu-*|i386/ubuntu-*|debian-*)
> wget --quiet --directory-prefix="$CUSTOM_PATH" \
> "$P4WHENCE/bin.linux26x86_64/p4d" \
> "$P4WHENCE/bin.linux26x86_64/p4" &&
> - chmod a+x "$CUSTOM_PATH/p4d" "$CUSTOM_PATH/p4" || {
> - rm -f "$CUSTOM_PATH/p4"
> - rm -f "$CUSTOM_PATH/p4d"
> - }
> + chmod a+x "$CUSTOM_PATH/p4d" "$CUSTOM_PATH/p4"
> + echo "$(tput setaf 6)Perforce Server Version$(tput sgr0)"
> + p4d -V
> + echo "$(tput setaf 6)Perforce Client Version$(tput sgr0)"
> + p4 -V
Isn't the && chain completely useless now, both here and in the other
cases? We let `set -e` do its thing, but we don't have any error
handling for the whole block anymore after we dropped the error message.
Patrick
next prev parent reply other threads:[~2026-10-26 11:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-12 14:38 [PATCH] ci: only warn about perforce/git-lfs/JGit on platforms that need them Harald Nordgren via GitGitGadget
2026-09-25 19:02 ` Junio C Hamano
2026-09-28 12:31 ` Patrick Steinhardt
2026-09-28 16:13 ` Harald Nordgren
2026-10-23 16:50 ` [PATCH v2] ci: fail the build if perforce, git-lfs, or JGit fail to install Harald Nordgren via GitGitGadget
2026-10-23 21:48 ` Junio C Hamano
2026-10-23 22:59 ` Harald Nordgren
2026-10-23 23:06 ` Junio C Hamano
2026-10-26 7:13 ` Patrick Steinhardt
2026-10-26 7:38 ` Harald Nordgren
2026-10-26 7:41 ` Harald Nordgren
2026-10-26 8:07 ` Patrick Steinhardt
2026-10-26 8:08 ` Harald Nordgren
2026-10-26 8:06 ` Patrick Steinhardt
2026-10-26 8:13 ` Harald Nordgren
2026-10-26 8:58 ` Patrick Steinhardt
2026-10-26 9:54 ` [PATCH v3 0/2] ci: fail the build if perforce, git-lfs " Harald Nordgren via GitGitGadget
2026-10-26 9:54 ` [PATCH v3 1/2] ci: drop quarantine removal for macos perforce binaries Harald Nordgren via GitGitGadget
2026-10-26 11:08 ` Patrick Steinhardt
2026-10-26 12:18 ` Harald Nordgren
2026-10-26 12:49 ` Harald Nordgren
2026-10-26 16:54 ` Junio C Hamano
2026-10-26 9:54 ` [PATCH v3 2/2] ci: fail the build if perforce, git-lfs, or JGit fail to install Harald Nordgren via GitGitGadget
2026-10-26 11:08 ` Patrick Steinhardt [this message]
2026-10-26 12:17 ` Harald Nordgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=at80okuHpoUjUYpQ@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=haraldnordgren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox