From: Patrick Steinhardt <ps@pks.im>
To: "Mark C. Chu-Carroll" <markchucarroll@fastmail.com>
Cc: git@vger.kernel.org, jltobler@gmail.com
Subject: Re: [PATCH v5 1/1] repo: add filtering options to "repo structure"
Date: Thu, 15 Oct 2026 17:52:24 +0200 [thread overview]
Message-ID: <atD2uH1pPJxH7pgR@pks.im> (raw)
In-Reply-To: <DM5HQ9U1JWFE.28OMPLQUD2E7P@fastmail.com>
On Thu, Oct 15, 2026 at 10:44:13AM -0400, Mark C. Chu-Carroll wrote:
> On Wed Oct 14, 2026 at 8:15 AM EDT, Patrick Steinhardt wrote:
> > On Tue, Oct 13, 2026 at 01:28:51PM -0400, Mark C. Chu-Carroll wrote:
> >> diff --git a/t/t1901-repo-structure.sh b/t/t1901-repo-structure.sh
> >> index 02cc2b594a..1d25ee14e5 100755
> >> --- a/t/t1901-repo-structure.sh
> >> +++ b/t/t1901-repo-structure.sh
> >> @@ -140,10 +140,208 @@ test_expect_success SHA1 'repository with references and objects' '
> >> @@ -186,13 +384,13 @@ test_expect_success SHA1 'lines and nul format' '
> >
> > I'd drop these while-at-it changes. If you want to include them they
> > should be part of a preparatory commit.
>
> Will drop. My reflex is to change all instances of something after
> a comment like this.
I think that's not the worst reflex to have, but in that case those
should go into a preparatory commit.
Patrick
next prev parent reply other threads:[~2026-10-15 15:52 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 16:45 [PATCH 0/1] repo: add filtering options to "repo structure" Mark C. Chu-Carroll
2026-09-24 16:45 ` [PATCH 1/1] " Mark C. Chu-Carroll
2026-09-30 16:28 ` Patrick Steinhardt
2026-10-05 18:52 ` Mark C. Chu-Carroll
2026-10-05 17:40 ` [PATCH v2 0/1] " Mark C. Chu-Carroll
2026-10-05 17:40 ` [PATCH v2 1/1] " Mark C. Chu-Carroll
2026-10-06 5:51 ` Patrick Steinhardt
2026-10-08 15:46 ` Kaartic Sivaraam
2026-10-09 15:49 ` Mark C. Chu-Carroll
2026-10-09 18:09 ` [PATCH v3 0/1] repo: add revision " Mark C. Chu-Carroll
2026-10-09 18:09 ` [PATCH v3 1/1] repo: add " Mark C. Chu-Carroll
2026-10-09 21:24 ` Junio C Hamano
2026-10-10 14:31 ` Mark C. Chu-Carroll
2026-10-10 15:05 ` [PATCH v4 0/1] repo: add revision " Mark C. Chu-Carroll
2026-10-10 15:05 ` [PATCH v4 1/1] repo: add " Mark C. Chu-Carroll
2026-10-13 11:50 ` Patrick Steinhardt
2026-10-13 13:56 ` Mark C. Chu-Carroll
2026-10-13 14:05 ` Patrick Steinhardt
2026-10-13 17:28 ` [PATCH v5 0/1] repo: add revision " Mark C. Chu-Carroll
2026-10-13 17:28 ` [PATCH v5 1/1] repo: add " Mark C. Chu-Carroll
2026-10-14 12:15 ` Patrick Steinhardt
2026-10-15 14:44 ` Mark C. Chu-Carroll
2026-10-15 15:52 ` Patrick Steinhardt [this message]
2026-10-15 14:46 ` [PATCH v6 0/1] repo: add revision " Mark C. Chu-Carroll
2026-10-15 14:46 ` [PATCH v6 1/1] repo: add " Mark C. Chu-Carroll
2026-10-15 15:12 ` Kristoffer Haugsbakk
2026-10-15 16:58 ` Mark C. Chu-Carroll
2026-10-15 17:03 ` [PATCH v7 0/1] repo: add revision " Mark C. Chu-Carroll
2026-10-15 17:03 ` [PATCH v7 1/1] repo: add " Mark C. Chu-Carroll
2026-10-15 17:05 ` [PATCH v7 0/1] repo: add revision " Mark C. Chu-Carroll
2026-10-15 17:05 ` [PATCH v7 1/1] repo: add " Mark C. Chu-Carroll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atD2uH1pPJxH7pgR@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=jltobler@gmail.com \
--cc=markchucarroll@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox