Git development
 help / color / mirror / Atom feed
From: Justin Tobler <jltobler@gmail.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 3/4] object-file: explicitly write ".keep" lockfile
Date: Mon, 19 Oct 2026 16:44:27 -0500	[thread overview]
Message-ID: <ataOnaLL1AzafGld@denethor> (raw)
In-Reply-To: <atW1Vh0b406cxCZJ@pks.im>

On 26/10/19 08:14AM, Patrick Steinhardt wrote:
> On Fri, Oct 16, 2026 at 04:37:15PM -0500, Justin Tobler wrote:

> Nit: now that all error paths call `error_errno()` I would have
> preferred to keep `ret` uninitialized and then assign the return value
> of `error_errno()` to it. But that's a minor detail only that does not
> warrant a reroll.

I've queued up locally this change a long with the removal of the extra
newline. If I don't get any other comments, I may just go ahead and send
it up.

Thanks,
-Justin

  reply	other threads:[~2026-10-19 21:44 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16  2:28 [PATCH 0/3] object-file: fix ".keep" lockfile ownership in ODB transactions Justin Tobler
2026-10-16  2:28 ` [PATCH 1/3] pack-write: lift and expose index-pack report parsing Justin Tobler
2026-10-16  6:58   ` Patrick Steinhardt
2026-10-16 17:30     ` Justin Tobler
2026-10-16  2:29 ` [PATCH 2/3] object-file: explicitly write ".keep" lockfile Justin Tobler
2026-10-16  6:58   ` Patrick Steinhardt
2026-10-16 18:37     ` Justin Tobler
2026-10-16  2:29 ` [PATCH 3/3] object-file: write ".keep" lockfiles during transaction commit Justin Tobler
2026-10-16  6:58   ` Patrick Steinhardt
2026-10-16 19:22     ` Justin Tobler
2026-10-16 21:37 ` [PATCH v2 0/4] object-file: fix ".keep" lockfile ownership in ODB transactions Justin Tobler
2026-10-16 21:37   ` [PATCH v2 1/4] pack-write: make index-pack output comment hash agnostic Justin Tobler
2026-10-16 21:37   ` [PATCH v2 2/4] pack-write: lift and expose index-pack report parsing Justin Tobler
2026-10-16 21:37   ` [PATCH v2 3/4] object-file: explicitly write ".keep" lockfile Justin Tobler
2026-10-19  6:14     ` Patrick Steinhardt
2026-10-19 21:44       ` Justin Tobler [this message]
2026-10-16 21:37   ` [PATCH v2 4/4] object-file: write ".keep" lockfiles during transaction commit Justin Tobler
2026-10-19  6:14     ` Patrick Steinhardt
2026-10-20 13:28   ` [PATCH v3 0/4] object-file: fix ".keep" lockfile ownership in ODB transactions Justin Tobler
2026-10-20 13:28     ` [PATCH v3 1/4] pack-write: make index-pack output comment hash agnostic Justin Tobler
2026-10-20 13:28     ` [PATCH v3 2/4] pack-write: lift and expose index-pack report parsing Justin Tobler
2026-10-20 13:28     ` [PATCH v3 3/4] object-file: explicitly write ".keep" lockfile Justin Tobler
2026-10-20 14:26       ` Patrick Steinhardt
2026-10-20 15:51         ` Justin Tobler
2026-10-21 16:47           ` Junio C Hamano
2026-10-20 13:29     ` [PATCH v3 4/4] object-file: write ".keep" lockfiles during transaction commit Justin Tobler
2026-10-20 14:15     ` [PATCH v3 0/4] object-file: fix ".keep" lockfile ownership in ODB transactions Patrick Steinhardt
2026-10-21 18:25     ` [PATCH v4 " Justin Tobler
2026-10-21 18:25       ` [PATCH v4 1/4] pack-write: make index-pack output comment hash agnostic Justin Tobler
2026-10-21 18:25       ` [PATCH v4 2/4] pack-write: lift and expose index-pack report parsing Justin Tobler
2026-10-21 18:25       ` [PATCH v4 3/4] object-file: explicitly write ".keep" lockfile Justin Tobler
2026-10-21 18:25       ` [PATCH v4 4/4] object-file: write ".keep" lockfiles during transaction commit Justin Tobler
2026-10-22  5:56       ` [PATCH v4 0/4] object-file: fix ".keep" lockfile ownership in ODB transactions Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ataOnaLL1AzafGld@denethor \
    --to=jltobler@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox