Git development
 help / color / mirror / Atom feed
From: Alejandro Colomar <alx+git@kernel.org>
To: git@vger.kernel.org
Cc: Andy Shevchenko <andy@kernel.org>,
	 Linus Torvalds <torvalds@linux-foundation.org>,
	Krzysztof Kozlowski <krzk@kernel.org>
Subject: git-ls-files(1) avoiding symlinks
Date: Fri, 6 Nov 2026 14:35:01 +0100	[thread overview]
Message-ID: <au3Tyaz_LoYDuskn@devuan> (raw)

[-- Attachment #1: Type: text/plain, Size: 1822 bytes --]

Hi!

Yesterday, we were discussing alternative methods for grepping source
code.  Here's a list of similar alternatives:

	$ find . -type f | xargs grep ARRAY_END;
	$ git ls-files | xargs grep ARRAY_END;
	$ git grep ARRAY_END;

The version using find(1) has some problems: it is slow, especially
after having built a kernel, when the directory is full of temporary
objects.

The version using git-grep(1) without IPC is the fastest, and doesn't
have any problems, but it is limited to just grep(1).  If we want to use
sed(1), or any other programs, we're out of luck.

A common program I want to use is grepc(1), which searches source code.
See for example this code for finding the creat(2) system call:

	$ git ls-files | grep '\.[ch]$' | xargs grepc creat;
	fs/open.c:SYSCALL_DEFINE2(creat, const char __user *, pathname, umode_t, mode)
	{
		int flags = O_CREAT | O_WRONLY | O_TRUNC;

		if (force_o_largefile())
			flags |= O_LARGEFILE;
		return do_sys_open(AT_FDCWD, pathname, flags, mode);
	}
	include/linux/syscalls.h:asmlinkage long sys_creat(const char __user *pathname, umode_t mode);
	tools/include/nolibc/fcntl.h:static __attribute__((unused))
	int creat(const char *path, mode_t mode)
	{
		return open(path, O_CREAT | O_WRONLY | O_TRUNC, mode);
	}

A problem with git-ls-files(1) is that it doesn't have a way to filter
files by type.  That is, it will list symlinks, which will affect the
search.  With find(1), I can control that with '-type f', which makes
sure I only search in regular files.  I'd like to have some feature in
git-ls-files(1) that allows me to print files of the specified type.
Since git(1) knows the type of the files, this should be doable without
much overhead, right?


Have a lovely day!
Alex

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

             reply	other threads:[~2026-11-06 13:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 13:35 Alejandro Colomar [this message]
2026-11-06 14:15 ` git-ls-files(1) avoiding symlinks D. Ben Knoble
2026-11-06 14:45   ` Alejandro Colomar
     [not found]     ` <AE63992D-7BEA-413D-A372-78708CFA8F6F@gmail.com>
2026-11-06 19:36       ` Alejandro Colomar
2026-11-06 20:16         ` Junio C Hamano
2026-11-06 21:06           ` Alejandro Colomar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=au3Tyaz_LoYDuskn@devuan \
    --to=alx+git@kernel.org \
    --cc=andy@kernel.org \
    --cc=git@vger.kernel.org \
    --cc=krzk@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox