Re: [PATCH v4 0/6] log: speed up --follow following renames for non-linear history

[Patrick Steinhardt <ps@pks.im>]

Hi Miklos,

On Fri, Oct 30, 2026 at 09:07:00PM +0100, Miklos Vajna wrote:
> Hi Patrick,
> 
> Thanks for the reviews of v3. Changes in v4:

please note that the expectation is that you answer to the review
comments directly instead of only answering reviews via the cover letter
of the next version. We want there to be discussions, and reviewers
should not have to figure out by themselves whether you did or did not
address specific concerns.

> - Patch 6/6 fixes the case you found, where the speedup lost history:
>   one side of the merge renamed the path, and the other side, whose
>   version the merge dropped, edited the old name. It uses your test.
>   I kept it separate from the speedup patch, which is complicated
>   enough already. With the extra check, the linux.git case still takes
>   about 37s.

Hmm, okay. But isn't it the case that your speedup patch introduces a
regression where we now don't follow history in some specific cases
anymore, and that regression was only introduced in the preceding
commit? So it's a bit curious to have this be an extra commit.

> - I also noticed that the simplify patch lost history with
>   --diff-merges=first-parent, which diffs merges only against their
>   first parent, but still walks all parents. Fixed that and added a
>   test for it to 1/6.

> Interdiff against v3:

Instead of an interdiff, could you please send a range-diff next time?
That makes it was easier to see which specific commits I need to have a
look at again, and it also shows diffs to commit messages.

Patrick