Git development
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Joy via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,
	"Kristoffer Haugsbakk@imap.fastmail.com>"
	<kristofferhaugsbakk@fastmail.com>,
	"Christian Couder>" <christian.couder@gmail.com>,
	"Usman Akinyemi@imap.fastmail.com>" <usmanakinyemi202@gmail.com>,
	Joie Joie <soniqjjj@gmail.com>,
	Tanga Joris <tangajoris@gmail.com>
Subject: Re: [PATCH] repo: zero-initialize configuration values
Date: Fri, 6 Nov 2026 15:16:52 +0100	[thread overview]
Message-ID: <au3hVGPuDyGVwOw8@pks.im> (raw)
In-Reply-To: <pull.2298.git.1793966368860.gitgitgadget@gmail.com>

On Fri, Nov 06, 2026 at 11:59:28AM +0000, Joy via GitGitGadget wrote:
> From: Joy Gundu <soniqjjj@gmail.com>
> 
> Use memset() to initialize repository configuration values to
> zero, removing the need for explicit zero and NULL assignments.
> Keep non-zero defaults initialized separately.
> 
> Signed-off-by: Joy Gundu <soniqjjj@gmail.com>
> ---
>     [Outreachy] repo: zero-initialize configuration values

So I guess this patch was split out because of our recent push to not
make further changes to `repo_config_values()`? If so, it would have
made sense to point that out explicitly both here, and in the original
thread that you've sent.

In any case, the patch is obviously correct and is a good improvement in
my opinion. So this looks good to me, thanks.

Patrick

  reply	other threads:[~2026-11-06 14:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 11:59 [PATCH] repo: zero-initialize configuration values Joy via GitGitGadget
2026-11-06 14:16 ` Patrick Steinhardt [this message]
2026-11-06 16:19   ` Joie Joie
2026-11-06 19:36   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=au3hVGPuDyGVwOw8@pks.im \
    --to=ps@pks.im \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=soniqjjj@gmail.com \
    --cc=tangajoris@gmail.com \
    --cc=usmanakinyemi202@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox