From: Patrick Steinhardt <ps@pks.im>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org, "SZEDER Gábor" <szeder.dev@gmail.com>
Subject: Re: [PATCH v4 0/7] odb: introduce object storage extension
Date: Wed, 28 Oct 2026 12:31:01 +0100 [thread overview]
Message-ID: <auHc9TeCfrCurKTM@pks.im> (raw)
In-Reply-To: <CAOLa=ZRWktyBmeeiMbPqnX_OkizqPA2mmGrnTABW7Pkk7DcKpA@mail.gmail.com>
On Wed, Oct 28, 2026 at 06:53:18AM -0400, Karthik Nayak wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> > Range-diff versus v3:
> >
> > 1: 906c3d3e3c3 = 1: f09fc3200f9 loose: drop unused `repo_write_loose_object_map()`
> > 2: 3d3bcf0f825 ! 2: 655e1de3b9d setup: introduce object storage extension
> > @@ Commit message
> > allows you to configure a different location for the ".git/objects"
> > directory.
> >
> > + Making the location of the "files" backend configurable is not he most
>
> s/he/the
Fixed locally, but I'll refrain from sending out a new version just to
fix this one typo.
> [snip]
>
> The rest looks good. Overall I'm happy with this version!
Thanks for your review!
Patrick
prev parent reply other threads:[~2026-10-28 11:31 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 8:55 [PATCH 0/7] odb: introduce object storage extension Patrick Steinhardt
2026-10-19 8:55 ` [PATCH 1/7] loose: drop unused `repo_write_loose_object_map()` Patrick Steinhardt
2026-10-19 20:21 ` Karthik Nayak
2026-10-20 8:49 ` Patrick Steinhardt
2026-10-20 18:30 ` Karthik Nayak
2026-10-19 8:55 ` [PATCH 2/7] setup: introduce object storage extension Patrick Steinhardt
2026-10-19 21:29 ` Karthik Nayak
2026-10-20 1:27 ` Junio C Hamano
2026-10-20 18:32 ` Karthik Nayak
2026-10-20 8:50 ` Patrick Steinhardt
2026-10-20 19:06 ` Karthik Nayak
2026-10-19 8:55 ` [PATCH 3/7] setup: allow overriding object storage format via environment Patrick Steinhardt
2026-10-19 21:34 ` Karthik Nayak
2026-10-20 8:50 ` Patrick Steinhardt
2026-10-20 19:08 ` Karthik Nayak
2026-10-19 8:55 ` [PATCH 4/7] builtin: expose the object storage format Patrick Steinhardt
2026-10-19 21:40 ` Karthik Nayak
2026-10-20 8:50 ` Patrick Steinhardt
2026-10-20 19:10 ` Karthik Nayak
2026-10-19 8:56 ` [PATCH 5/7] builtin/init: introduce handling of " Patrick Steinhardt
2026-10-19 8:56 ` [PATCH 6/7] builtin/clone: introduce "--object-storage-format=" Patrick Steinhardt
2026-10-19 8:56 ` [PATCH 7/7] builtin/submodule: propagate "--object-storage-format=" Patrick Steinhardt
2026-10-21 5:39 ` [PATCH v2 0/7] odb: introduce object storage extension Patrick Steinhardt
2026-10-21 5:39 ` [PATCH v2 1/7] loose: drop unused `repo_write_loose_object_map()` Patrick Steinhardt
2026-10-21 5:39 ` [PATCH v2 2/7] setup: introduce object storage extension Patrick Steinhardt
2026-10-21 5:39 ` [PATCH v2 3/7] setup: allow overriding object storage format via environment Patrick Steinhardt
2026-10-21 5:39 ` [PATCH v2 4/7] builtin: expose the object storage format Patrick Steinhardt
2026-10-21 5:39 ` [PATCH v2 5/7] builtin/init: introduce handling of " Patrick Steinhardt
2026-10-21 14:23 ` Karthik Nayak
2026-10-23 5:33 ` Patrick Steinhardt
2026-10-21 5:39 ` [PATCH v2 6/7] builtin/clone: introduce "--object-storage-format=" Patrick Steinhardt
2026-10-21 5:39 ` [PATCH v2 7/7] builtin/submodule: propagate "--object-storage-format=" Patrick Steinhardt
2026-10-21 14:31 ` [PATCH v2 0/7] odb: introduce object storage extension Karthik Nayak
2026-10-23 11:49 ` [PATCH v3 " Patrick Steinhardt
2026-10-23 11:49 ` [PATCH v3 1/7] loose: drop unused `repo_write_loose_object_map()` Patrick Steinhardt
2026-10-23 11:49 ` [PATCH v3 2/7] setup: introduce object storage extension Patrick Steinhardt
2026-10-24 14:50 ` SZEDER Gábor
2026-10-26 10:05 ` Patrick Steinhardt
2026-10-26 11:22 ` Karthik Nayak
2026-10-26 11:53 ` Patrick Steinhardt
2026-10-23 11:49 ` [PATCH v3 3/7] setup: allow overriding object storage format via environment Patrick Steinhardt
2026-10-26 11:25 ` Karthik Nayak
2026-10-26 11:53 ` Patrick Steinhardt
2026-10-23 11:49 ` [PATCH v3 4/7] builtin: expose the object storage format Patrick Steinhardt
2026-10-23 11:49 ` [PATCH v3 5/7] builtin/init: introduce handling of " Patrick Steinhardt
2026-10-23 11:49 ` [PATCH v3 6/7] builtin/clone: introduce "--object-storage-format=" Patrick Steinhardt
2026-10-23 11:49 ` [PATCH v3 7/7] builtin/submodule: propagate "--object-storage-format=" Patrick Steinhardt
2026-10-26 11:35 ` [PATCH v3 0/7] odb: introduce object storage extension Karthik Nayak
2026-10-26 11:53 ` Patrick Steinhardt
2026-10-27 6:59 ` [PATCH v4 " Patrick Steinhardt
2026-10-27 6:59 ` [PATCH v4 1/7] loose: drop unused `repo_write_loose_object_map()` Patrick Steinhardt
2026-10-27 6:59 ` [PATCH v4 2/7] setup: introduce object storage extension Patrick Steinhardt
2026-10-27 6:59 ` [PATCH v4 3/7] setup: allow overriding object storage format via environment Patrick Steinhardt
2026-10-27 6:59 ` [PATCH v4 4/7] builtin: expose the object storage format Patrick Steinhardt
2026-10-27 6:59 ` [PATCH v4 5/7] builtin/init: introduce handling of " Patrick Steinhardt
2026-10-27 6:59 ` [PATCH v4 6/7] builtin/clone: introduce "--object-storage-format=" Patrick Steinhardt
2026-10-27 6:59 ` [PATCH v4 7/7] builtin/submodule: propagate "--object-storage-format=" Patrick Steinhardt
2026-10-28 10:53 ` [PATCH v4 0/7] odb: introduce object storage extension Karthik Nayak
2026-10-28 11:31 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auHc9TeCfrCurKTM@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox