From: Patrick Steinhardt <ps@pks.im>
To: Srujith A Poojary via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Usman Akinyemi <usmanakinyemi202@gmail.com>,
Srujith A Poojary <poojarysrujith@gmail.com>
Subject: Re: [PATCH v3] [Outreachy PATCH] t0001: avoid pipes in test scripts
Date: Thu, 29 Oct 2026 13:12:05 +0100 [thread overview]
Message-ID: <auM4FazXNNwLzM3-@pks.im> (raw)
In-Reply-To: <pull.2260.v3.git.1792732388827.gitgitgadget@gmail.com>
On Fri, Oct 23, 2026 at 05:13:08AM +0000, Srujith A Poojary via GitGitGadget wrote:
> From: Srujith Poojary <poojarysrujith@gmail.com>
>
> Avoid piping output from git version directly into sed to ensure
>
> that any command failure is properly caught by test scripts.
Formatting of your commit message is off a bit with an empty line in
the middle of the sentence.
> diff --git a/t/t0001-init.sh b/t/t0001-init.sh
> index f1d227f271..c8c74f681b 100755
> --- a/t/t0001-init.sh
> +++ b/t/t0001-init.sh
> @@ -678,7 +678,8 @@ test_expect_success 'default ref format' '
> sane_unset GIT_DEFAULT_REF_STORAGE_FORMAT &&
> git init refformat
> ) &&
> - git version --build-options | sed -ne "s/^default-ref-storage-format: //p" >expect &&
> + git version --build-options >build-options &&
> + sed -ne "s/^default-ref-storage-format: //p" build-options >expect &&
> git -C refformat rev-parse --show-ref-storage-format >actual &&
> test_cmp expect actual
> '
The changes look good to me though. Thanks!
Patrick
next prev parent reply other threads:[~2026-10-29 12:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-18 4:55 [PATCH] [Outreachy PATCH] t0001: avoid pipes in test scripts Srujith A Poojary via GitGitGadget
2026-10-21 22:03 ` Usman Akinyemi
2026-10-22 10:50 ` [PATCH v2] " Srujith A Poojary via GitGitGadget
2026-10-22 10:53 ` Srujith Poojary
2026-10-22 17:24 ` Junio C Hamano
2026-10-23 4:34 ` Srujith Poojary
2026-10-23 5:13 ` [PATCH v3] " Srujith A Poojary via GitGitGadget
2026-10-23 16:23 ` Srujith Poojary
2026-10-29 12:12 ` Patrick Steinhardt [this message]
2026-10-29 14:36 ` Srujith Poojary
2026-10-29 14:34 ` [PATCH v4] " Srujith A Poojary via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auM4FazXNNwLzM3-@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=poojarysrujith@gmail.com \
--cc=usmanakinyemi202@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox