From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] add -i: hide init/clear_add_i_state() functions
Date: Fri, 30 Oct 2026 10:38:04 +0100 [thread overview]
Message-ID: <auRlfDXPhp3RjNyk@pks.im> (raw)
In-Reply-To: <xmqqh5i58uo0.fsf@gitster.g>
On Wed, Oct 28, 2026 at 12:57:51PM -0700, Junio C Hamano wrote:
> The "add -i" machinery is encapsulated in run_add_i() function,
> which uses init_add_i_state() to initialize the machinery, does its
> thing, and clear_add_i_state() to tear it down. External callers
> have no need to call anything other than run_add_i().
>
> Make init/clear_add_i_state() file-scope static functions, and
> "struct add_i_state" type as well.
Nice cleanup. For historical context, these declarations are not needed
anymore starting with d51b61f5dab (add-patch: remove dependency on
"add-interactive" subsystem, 2026-03-02).
Thanks!
Patrick
next prev parent reply other threads:[~2026-10-30 9:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 19:57 [PATCH] add -i: hide init/clear_add_i_state() functions Junio C Hamano
2026-10-28 20:48 ` Ben Knoble
2026-10-30 9:38 ` Patrick Steinhardt [this message]
2026-10-30 15:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auRlfDXPhp3RjNyk@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox