From: Justin Tobler <jltobler@gmail.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 0/4] loose: fix migrating "loose-object-idx" with batch fsync
Date: Fri, 30 Oct 2026 10:40:30 -0500 [thread overview]
Message-ID: <auS6XMchhyuTF_VJ@denethor> (raw)
In-Reply-To: <auQ3FTXbn1awcP70@pks.im>
On 26/10/30 07:20AM, Patrick Steinhardt wrote:
> On Thu, Oct 29, 2026 at 06:22:16PM -0500, Justin Tobler wrote:
> > Changes since V2:
> > - Reading the src mapping file is now done prior to acquiring the lock
> > to reduce the critical window.
> > - Added a comment to `loose_object_idx_merge()` and updated some
> > commit messages to improve clarity.
>
> The changes and range-diff both look exacty as expected, so I'm happy
> with this version. Thanks!
Thanks for the review!
-Justin
next prev parent reply other threads:[~2026-10-30 15:40 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 23:40 [PATCH] tmp-objdir: merge loose object index when migrating tmpdir Justin Tobler
2026-10-23 12:19 ` Patrick Steinhardt
2026-10-23 21:25 ` Justin Tobler
2026-10-26 6:39 ` Patrick Steinhardt
2026-10-26 17:58 ` Justin Tobler
2026-10-29 0:24 ` [PATCH v2 0/4] loose: fix migrating "loose-object-idx" with batch fsync Justin Tobler
2026-10-29 0:24 ` [PATCH v2 1/4] loose: use finite timeout when locking "loose-object-idx" file Justin Tobler
2026-10-29 8:05 ` Patrick Steinhardt
2026-10-29 0:24 ` [PATCH v2 2/4] loose: lift loose object index parsing logic into helper Justin Tobler
2026-10-29 8:05 ` Patrick Steinhardt
2026-10-29 21:10 ` Justin Tobler
2026-10-29 0:24 ` [PATCH v2 3/4] loose: lift loose object index writing " Justin Tobler
2026-10-29 8:05 ` Patrick Steinhardt
2026-10-29 21:18 ` Justin Tobler
2026-10-29 0:24 ` [PATCH v2 4/4] tmp-objdir: merge loose object index when migrating tmpdir Justin Tobler
2026-10-29 8:05 ` Patrick Steinhardt
2026-10-29 21:20 ` Justin Tobler
2026-10-29 22:22 ` [PATCH v2 0/4] loose: fix migrating "loose-object-idx" with batch fsync Junio C Hamano
2026-10-29 22:45 ` Justin Tobler
2026-10-29 23:22 ` [PATCH v3 " Justin Tobler
2026-10-29 23:22 ` [PATCH v3 1/4] loose: use finite timeout when locking "loose-object-idx" file Justin Tobler
2026-10-30 10:43 ` Karthik Nayak
2026-10-29 23:22 ` [PATCH v3 2/4] loose: lift loose object index parsing logic into helper Justin Tobler
2026-10-30 10:50 ` Karthik Nayak
2026-10-30 15:31 ` Justin Tobler
2026-10-29 23:22 ` [PATCH v3 3/4] loose: lift loose object index writing " Justin Tobler
2026-10-29 23:22 ` [PATCH v3 4/4] tmp-objdir: merge loose object index when migrating tmpdir Justin Tobler
2026-10-30 11:55 ` Karthik Nayak
2026-10-30 15:40 ` Justin Tobler
2026-10-30 6:20 ` [PATCH v3 0/4] loose: fix migrating "loose-object-idx" with batch fsync Patrick Steinhardt
2026-10-30 15:40 ` Justin Tobler [this message]
2026-10-30 10:38 ` Karthik Nayak
2026-10-30 15:43 ` Justin Tobler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auS6XMchhyuTF_VJ@denethor \
--to=jltobler@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox