From: Patrick Steinhardt <ps@pks.im>
To: Derrick Stolee <stolee@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 00/10] commit-graph: several refactorings for writing commit graphs
Date: Thu, 5 Nov 2026 14:55:16 +0100 [thread overview]
Message-ID: <auyKxKX4l3QmGG1y@pks.im> (raw)
In-Reply-To: <0e74f6c3-2f43-4829-a071-27e96ab5e87b@gmail.com>
On Wed, Nov 04, 2026 at 11:37:11AM -0500, Derrick Stolee wrote:
> On 11/4/2026 10:57 AM, Patrick Steinhardt wrote:
> > Hi,
> >
> > this patch series includes several small cleanups for the interfaces for
> > writing commit graphs. Most importantly, the series refactors options so
> > that they all get passed via `struct commit_graph_write_options`. These
> > cleanups are split out of a bigger change to make reading and writing
> > commit-graphs pluggable via the object database bakcend.
> These cleanups look great. They are carefully constructed to be as
> simple as possible at each step. It's good to bring some of these
> conventions into a more modern style and to simplify things in the
> process.
Thanks for your review!
Patrick
next prev parent reply other threads:[~2026-11-05 13:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 15:57 [PATCH 00/10] commit-graph: several refactorings for writing commit graphs Patrick Steinhardt
2026-11-04 15:57 ` [PATCH 01/10] commit-graph: rename `struct commit_graph_opts` Patrick Steinhardt
2026-11-04 15:57 ` [PATCH 02/10] commit-graph: pass writer flags via options Patrick Steinhardt
2026-11-04 15:57 ` [PATCH 03/10] commit-graph: drop `NULL` checks for write options Patrick Steinhardt
2026-11-04 15:57 ` [PATCH 04/10] commit-graph: drop redundant flags in write context Patrick Steinhardt
2026-11-04 19:18 ` Junio C Hamano
2026-11-04 15:57 ` [PATCH 05/10] commit-graph: merge the two commit graph writers Patrick Steinhardt
2026-11-04 16:33 ` Derrick Stolee
2026-11-04 15:57 ` [PATCH 06/10] commit-graph: move remaining write parameters into options Patrick Steinhardt
2026-11-04 16:34 ` Derrick Stolee
2026-11-04 17:49 ` Kristofer Karlsson
2026-11-05 13:20 ` Patrick Steinhardt
2026-11-05 15:07 ` Kristofer Karlsson
2026-11-04 15:57 ` [PATCH 07/10] commit-graph: fix mixup of write/verify flags Patrick Steinhardt
2026-11-04 15:57 ` [PATCH 08/10] builtin/commit-graph: set flags directly Patrick Steinhardt
2026-11-04 15:57 ` [PATCH 09/10] odb/source-files: verify commit-graphs as part of fsck Patrick Steinhardt
2026-11-04 15:57 ` [PATCH 10/10] commit-graph: modernize function names Patrick Steinhardt
2026-11-04 16:37 ` [PATCH 00/10] commit-graph: several refactorings for writing commit graphs Derrick Stolee
2026-11-05 13:55 ` Patrick Steinhardt [this message]
2026-11-05 13:57 ` Patrick Steinhardt
2026-11-05 15:18 ` Derrick Stolee
2026-11-05 15:33 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auyKxKX4l3QmGG1y@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox