From: Patrick Steinhardt <ps@pks.im>
To: Christoph Weiss <weiss@wsoptics.de>
Cc: git@vger.kernel.org
Subject: Re: [BUG] Geometric maintenance prunes commits without updating commit-graph
Date: Thu, 19 Nov 2026 13:50:25 +0100 [thread overview]
Message-ID: <av7wkQXxYrzAJInT@pks.im> (raw)
In-Reply-To: <ba964c70-60ab-4b7a-a0fa-6e028e401a09@wsoptics.de>
Hi,
On Thu, Nov 05, 2026 at 07:41:26AM +0100, Christoph Weiss wrote:
> Hi,
>
> After updating our internal Forgejo instance from 16 to 17, many of our
> repositories' health checks started failing. This appears to be due to the
> update entailing a switch in Git from 2.52 to 2.54, which in turn changed
> the default maintenance strategy from `gc` to `geometric`.
thanks for the report, makes sense.
I think the way to fix this is to move generation of commit graphs into
`odb_optimize()`, which would give us a lot more control over when
exactly we generate them. And that would allow us to figure out whether
we have discarded any objects in the first place, in which case we'd
rewrite the commit graph.
That also aligns with my other in-flight patch series that makes commit
graphs pluggable in the first place. Once they're an implementation
deatil of the object database backend, it's only natural to also write
them as part of `odb_optimize()`.
That means thought that I can only fix this once [1] has landed, as any
changes I'd make to fix the reported issue would conflict. But once it
did I'll send such a patch series.
Thanks!
Patrick
prev parent reply other threads:[~2026-11-19 12:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 6:41 [BUG] Geometric maintenance prunes commits without updating commit-graph Christoph Weiss
2026-11-19 12:50 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av7wkQXxYrzAJInT@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=weiss@wsoptics.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox