From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>,
Adam Dinwoodie <adam@dinwoodie.org>
Subject: Re: [PATCH v3] setup: fix hash algorithm detection
Date: Thu, 19 Nov 2026 22:20:26 +0000 [thread overview]
Message-ID: <av92KlePF0GKyQDh@fruit.crustytoothpaste.net> (raw)
In-Reply-To: <xmqqmrr4zsi2.fsf@gitster.g>
[-- Attachment #1: Type: text/plain, Size: 2808 bytes --]
On 2026-11-19 at 16:38:13, Junio C Hamano wrote:
> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>
> > Our current hash algorithm selection code has a few different problems.
> > First, we do not actually default to GIT_HASH_DEFAULT. Second, if we
> > have an algorithm chosen by init.defaultObjectFormat and we re-init a
> > repository, we will change the hash algorithm, which is very much not
> > desired.
>
> Can we end the "first" sentence with a reason? We do not actually
> default to GIT_HASH_DEFAULT because we initialize a variable to
> SHA1_LEGACY and we do not consider it as "nowhere the user specifies
> which algorithm they want", or something?
I can expand on that.
> > Let's restructure this code slightly. First, if an algorithm was
> > selected on the command line, assume that's what the user wanted.
> > Otherwise, the other options should only be chosen if our repository
> > doesn't exist (that is, repo_fmt->version is -1) or it's specifically
> > detected as having no hash algorithm. In that case, first use the
> > environment, then the config, and finally, the default algorithm.
>
> In the current code, does "it's specifically having no hash
> algorithm" ever happen? Or is it our wish in near future to have
> such a state to allow "the first use determines the hash algorithm
> used" mode?
It should not as far as I can tell, but we have a bunch of different
cases, including the clone case, and I'm not 100% sure if that actually
ever happens.
> > - /*
> > - * If we already have an initialized repo, don't allow the user to
> > - * specify a different algorithm, as that could cause corruption.
> > - * Otherwise, if the user has specified one on the command line, use it.
> > - */
>
> I think the first two lines is still relevant and serves as a
> caution to whoever will be mucking with this function in the future.
> The last sentence is not quite right in that following the user's
> wish is not limited to the command line instruction (if they tell us
> via an environment variable, we would honor it).
>
> Oh, it just occured to me while I was writing the above
> parenthesized comment. If I have ~/.gitconfig that was modified via
> "git config set --global init.defaultObjectFormat sha256", would
> that count as "the user has specified"?
I'll rewrite the comment. The "user has specified one on the command
line" means with `--object-format`, but the user could specify one with
`init.defaultObjectFormat`. The difference is we scream if the former
mismatches with the repository, whereas if the repository is already
initialized, we ignore `GIT_DEFAULT_HASH` and
`init.defaultObjectFormat`.
--
brian m. carlson (they/them)
Toronto, Ontario, CA
Speaking for myself only
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 325 bytes --]
prev parent reply other threads:[~2026-11-19 22:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 16:50 Default object format for new repositories in Git v3 Adam Dinwoodie
2026-11-06 20:46 ` brian m. carlson
2026-11-08 1:16 ` [PATCH] setup: default hash algo to GIT_HASH_DEFAULT brian m. carlson
2026-11-08 4:42 ` Junio C Hamano
2026-11-08 14:38 ` brian m. carlson
2026-11-08 18:22 ` Junio C Hamano
2026-11-09 2:21 ` Junio C Hamano
2026-11-09 9:54 ` Patrick Steinhardt
2026-11-13 22:17 ` [PATCH v2] setup: fix hash algorithm detection brian m. carlson
2026-11-14 0:16 ` Junio C Hamano
2026-11-16 6:22 ` Patrick Steinhardt
2026-11-19 1:06 ` [PATCH v3] " brian m. carlson
2026-11-19 9:52 ` Patrick Steinhardt
2026-11-19 16:26 ` Junio C Hamano
2026-11-19 16:38 ` Junio C Hamano
2026-11-19 22:20 ` brian m. carlson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av92KlePF0GKyQDh@fruit.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=adam@dinwoodie.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox