From: Patrick Steinhardt <ps@pks.im>
To: Derrick Stolee <stolee@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 0/2] unpack-trees.c w/o the_repository
Date: Wed, 11 Nov 2026 13:48:48 +0100 [thread overview]
Message-ID: <avRkMPUmkqoCGmQC@pks.im> (raw)
In-Reply-To: <37267fd4-c565-4559-9c5c-01d58cd0426d@gmail.com>
On Tue, Nov 10, 2026 at 08:22:26AM -0500, Derrick Stolee wrote:
> On 11/9/2026 3:54 PM, Junio C Hamano wrote:
> > unpack_trees() API serves as low-level functions to implement merge
> > and checkout. It heavily relies on the_repository, making it clear
> > it only works with that repository instance. We however can use the
> > repository instance pointed at by key data structures passed
> > throughout the callchain.
> >
> > This is almost the exact copy of what I have at
> >
> > https://lore.kernel.org/git/xmqqtsltbfdv.fsf@gitster.g/
> >
> > The only changes since that version are removals of two blank lines.
> LGTM.
Likewise, I'm happy with this version. Thanks!
Patrick
prev parent reply other threads:[~2026-11-11 12:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 1:26 [PATCH 1/2] unpack-trees: lose USE_THE_REPOSITORY Junio C Hamano
2026-11-07 1:29 ` [PATCH 2/2] unpack-trees: consistently use "struct index_state *istate" Junio C Hamano
2026-11-09 13:46 ` Derrick Stolee
2026-11-09 13:41 ` [PATCH 1/2] unpack-trees: lose USE_THE_REPOSITORY Patrick Steinhardt
2026-11-09 19:30 ` Junio C Hamano
2026-11-10 7:04 ` Patrick Steinhardt
2026-11-10 16:13 ` Junio C Hamano
2026-11-10 16:40 ` Patrick Steinhardt
2026-11-09 13:45 ` Derrick Stolee
2026-11-09 20:54 ` [PATCH v2 0/2] unpack-trees.c w/o the_repository Junio C Hamano
2026-11-09 20:54 ` [PATCH v2 1/2] unpack-trees: lose USE_THE_REPOSITORY Junio C Hamano
2026-11-09 20:54 ` [PATCH v2 2/2] unpack-trees: consistently use "struct index_state *istate" Junio C Hamano
2026-11-10 13:22 ` [PATCH v2 0/2] unpack-trees.c w/o the_repository Derrick Stolee
2026-11-10 17:28 ` Junio C Hamano
2026-11-11 12:48 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avRkMPUmkqoCGmQC@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox