git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@gmail.com>
To: Pavel Roskin <proski@gnu.org>
Cc: git <git@vger.kernel.org>, Charles Lever <cel@citi.umich.edu>
Subject: Re: StGIT: "stg new" vs "stg new --force"
Date: Mon, 16 Jan 2006 08:18:07 +0000	[thread overview]
Message-ID: <b0943d9e0601160018x206faf9ck@mail.gmail.com> (raw)
In-Reply-To: <1137144291.20073.104.camel@dv>

Hi Pavel,

On 13/01/06, Pavel Roskin <proski@gnu.org> wrote:
> Maybe I don't understand something in StGIT, but it seems strange that
> "stg new" creates empty patch by default and requires "--force" to
> create a non-empty patch.

The 'new' command would fail to create a new patch if there are
changes in the tree.

I also find myself using the '--force' option most of the time. Even
when I create a an empty patch, I use to run 'status' before. The
current implementation is closer to Quilt where, AFAIK, you first
create a new patch and use 'add' for every modified file. Since 'add'
has a different meaning in StGIT, it might also make sense to remove
the '--force' option.

> 1) "stg new --force" becomes "stg new" and "stg new" becomes "stg new
> --empty", i.e. empty files can only be created with the "--empty"
> switch.
> 2) "stg new --force" becomes "stg record" or something.
> 3) "stg new --force" becomes "stg new --record" or something.
> 4) "stg new" works both with and without modified files.

Regarding (1), the newly created patch is empty anyway, you would need
to run 'refresh' to add the modified patches to it ('stg series -e'
would show the empty patches prefixed with a 0).

Anyway, I would also prefer option 4. If there are no objections, I'll
modify StGIT accordingly. It would also be useful to have a wiki page
about StGIT vs. Quilt to show the main differences.

--
Catalin

  parent reply	other threads:[~2006-01-16  8:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-13  9:24 StGIT: "stg new" vs "stg new --force" Pavel Roskin
2006-01-13  9:34 ` Karl Hasselström
2006-01-16  8:18 ` Catalin Marinas [this message]
2006-01-17 17:01   ` Pavel Roskin
2006-01-17 21:57     ` Yann Dirson
2006-01-17 23:16       ` Pavel Roskin
2006-01-18 19:37         ` Yann Dirson
2006-01-19  0:49           ` Pavel Roskin
2006-01-19 21:38             ` Yann Dirson
2006-01-20  6:23               ` Pavel Roskin
2006-01-20 18:22                 ` J. Bruce Fields
2006-01-24  5:30                   ` Pavel Roskin
2006-01-24 17:54                     ` J. Bruce Fields
2006-01-24 18:17                       ` Pavel Roskin
2006-01-24 21:23                         ` Catalin Marinas
2006-01-21 18:24         ` Catalin Marinas
2006-01-22  5:05           ` Pavel Roskin
2006-01-21 18:20       ` Catalin Marinas
2006-01-21 18:31     ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0943d9e0601160018x206faf9ck@mail.gmail.com \
    --to=catalin.marinas@gmail.com \
    --cc=cel@citi.umich.edu \
    --cc=git@vger.kernel.org \
    --cc=proski@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).