From: "Catalin Marinas" <catalin.marinas@gmail.com>
To: "Yann Dirson" <ydirson@altern.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] Look for a commit's parents in the standard way.
Date: Sun, 20 Aug 2006 11:43:22 +0100 [thread overview]
Message-ID: <b0943d9e0608200343t517ec29dw2b6b49d9d69dbad5@mail.gmail.com> (raw)
In-Reply-To: <20060814165544.20350.41590.stgit@gandelf.nowhere.earth>
On 14/08/06, Yann Dirson <ydirson@altern.org> wrote:
> This has the direct effect of taking info/grafts into account, since
> ignoring it only causes confusion.
I don't know the difference but is there any between parsing the
commit file and using git-rev-list --parents?
> + self.__parents = split(_output_lines('git-rev-list --parents --max-count=1 %s' % id_hash)[0])[1:]
Instead of using the split() method, you could call
_output_lines('git-rev-list --parents --max-count=1 %s' %
id_hash)[0].split()[1:]. Maybe that's why they might deprecate the
global split method.
Setting self.__parents by calling get-rev-list would have a
performance impact on the push operation. I think we could remove the
__parents variable and only call git-rev-parse in get_parents() or
get_parent().
--
Catalin
next prev parent reply other threads:[~2006-08-20 10:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-14 16:53 [PATCH 0/2] Series short description Yann Dirson
2006-08-14 16:55 ` [PATCH 1/2] Add a --parent flag to "stgit pick" Yann Dirson
2006-08-14 16:55 ` [PATCH 2/2] Look for a commit's parents in the standard way Yann Dirson
2006-08-20 10:43 ` Catalin Marinas [this message]
2006-08-22 6:42 ` Junio C Hamano
2006-09-03 19:36 ` Yann Dirson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0943d9e0608200343t517ec29dw2b6b49d9d69dbad5@mail.gmail.com \
--to=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=ydirson@altern.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).