From: "Catalin Marinas" <catalin.marinas@gmail.com>
To: "Karl Hasselström" <kha@treskal.com>
Cc: "Petr Baudis" <pasky@suse.cz>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] New stg command: assimilate
Date: Mon, 23 Oct 2006 12:52:20 +0100 [thread overview]
Message-ID: <b0943d9e0610230452m70d25e91x9e9604ed4eac33ea@mail.gmail.com> (raw)
In-Reply-To: <20061022181256.GA30295@diana.vm.bytemark.co.uk>
On 22/10/06, Karl Hasselström <kha@treskal.com> wrote:
> On 2006-10-22 19:43:08 +0200, Petr Baudis wrote:
>
> > Dear diary, on Sun, Oct 22, 2006 at 03:08:02PM CEST, I got a letter
> > where Karl Hasselström <kha@treskal.com> said that...
> >
> > > Introduce an "assimilate" command, with no options. It takes any
> > > GIT commits committed on top of your StGIT patch stack and
> > > converts them into StGIT patches.
> >
> > Hmm, isn't this what stg uncommit does?
> >
> > Well, I'm not sure if what uncommit takes is from below the stack or
> > above the stack, but if it's the former, it would still IMHO make
> > more sense to just tell that StGIT with a switch or something.
>
> Yes, you're correct in that uncommit and assimilate add existing
> commits to the StGIT stack, but in different ends: uncommit grows the
> stack by incorporating commits that precede it, while assimilate grows
> the stack by incorporating commits that follows it.
I think I also prefer a separate command for this as they have
slightly different goals and users could easily confuse the options of
a more powerful 'uncommit'.
--
Catalin
next prev parent reply other threads:[~2006-10-23 11:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-22 13:05 [PATCH 0/2] Resistance is futile; you _will_ be assimilated Karl Hasselström
2006-10-22 13:08 ` [PATCH 1/2] New stg command: assimilate Karl Hasselström
2006-10-22 17:43 ` Petr Baudis
2006-10-22 18:12 ` Karl Hasselström
2006-10-23 11:52 ` Catalin Marinas [this message]
2006-10-25 16:32 ` Karl Hasselström
2006-10-25 16:41 ` Catalin Marinas
2006-10-26 8:32 ` Karl Hasselström
2006-10-22 13:08 ` [PATCH 2/2] Regression test for "stg assimilate" Karl Hasselström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0943d9e0610230452m70d25e91x9e9604ed4eac33ea@mail.gmail.com \
--to=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=kha@treskal.com \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).