From: "Catalin Marinas" <catalin.marinas@gmail.com>
To: "Marco Costalba" <mcostalba@gmail.com>
Cc: "Karl Hasselström" <kha@treskal.com>, git@vger.kernel.org
Subject: Re: [PATCH] Print progress message to stderr, not stdout
Date: Mon, 4 Dec 2006 09:17:16 +0000 [thread overview]
Message-ID: <b0943d9e0612040117y6554b891yaf6eb59d0d52ebf0@mail.gmail.com> (raw)
In-Reply-To: <e5bfff550612020520w3ad48a09xfdde63b9050a75cf@mail.gmail.com>
On 02/12/06, Marco Costalba <mcostalba@gmail.com> wrote:
> On 11/11/06, Karl Hasselström <kha@treskal.com> wrote:
> > Printing progress messages to stdout causes them to get mixed up with
> > the actual output of the program. Using stderr is much better, since
> > the user can then redirect the two components separately.
>
> This patch breaks qgit.
>
> GUI interface to stgit pop and push commands is broken because a
> command that prints to stderr is considered a failing one by qgit.
>
> I would kindly ask you to:
>
> 1 - Revert the patch. That would be the best. You can use a prefix to
> printed message instead, see git pull, something like 'stg: bla bla
> bla' . In any case, IMHO, using stderr for normal activity logging
> does not sound like a great idea in general.
>
> 2 - At least add a '-v' '--verbose' option that defaults to quiet so
> to not break back compatibility.
Since there are other tools relying on a clean stderr, I think I would
revert it and add a verbose flag and/or config option. Karl, any
thoughts on this (since you sent the patch)?
--
next prev parent reply other threads:[~2006-12-04 9:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-11 12:16 [PATCH] Print progress message to stderr, not stdout Karl Hasselström
2006-12-02 13:20 ` Marco Costalba
2006-12-04 9:17 ` Catalin Marinas [this message]
2006-12-04 15:37 ` Karl Hasselström
2006-12-04 18:34 ` Marco Costalba
2006-12-04 22:13 ` Catalin Marinas
2006-12-05 6:11 ` Marco Costalba
2006-12-05 7:41 ` Johannes Schindelin
2006-12-05 9:06 ` Karl Hasselström
2006-12-05 9:06 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0943d9e0612040117y6554b891yaf6eb59d0d52ebf0@mail.gmail.com \
--to=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=kha@treskal.com \
--cc=mcostalba@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).