From: "Catalin Marinas" <catalin.marinas@gmail.com>
To: "Yann Dirson" <ydirson@altern.org>
Cc: "GIT list" <git@vger.kernel.org>
Subject: Re: [PATCH 1/3] Document some current bugs and add to the TODO list.
Date: Tue, 5 Dec 2006 17:30:56 +0000 [thread overview]
Message-ID: <b0943d9e0612050930t187e65c4g6a3c44ea1fefc940@mail.gmail.com> (raw)
In-Reply-To: <20061130002717.21981.38049.stgit@gandelf.nowhere.earth>
Hi Yann,
See some comments below (I removed those which I am OK with or I fixed).
On 30/11/06, Yann Dirson <ydirson@altern.org> wrote:
> +- numeric shortcuts for naming patches near top (eg. +1, -2)
We currently have the -n option for push and pop that accepts number.
Because of python, you can also, for example, push to the last but one
with "push -n -1" (similar for pop). Do you mean shortcuts for the
"goto" command?
> +- refuse to "stg init" a branch known as remote (through .git/remotes/,
> + .git/branches/ or any other info)
I think it is up to the user not to do this. You would first need to
check out such a branch anyway.
> +- cannot use "stg refresh file" after "cg-rm file"
It seems to work for me. Can you send some log messages?
> +- "stg goto $(stg top)" fails with unhandled exception
It works for me. What StGIT version do you use?
> +- at least "commit is not robust wrt out-of-diskspace condition:
> +|deps$ stg commit
> +|error: git-checkout-index: unable to write file MANIFEST
> +|error: git-checkout-index: unable to write file META.yml
> +|error: git-checkout-index: unable to write file Makefile.PL
> +|error: git-checkout-index: unable to write file doc/README.dbk.xml
> +|error: git-checkout-index: unable to write file graph-includes
> +|error: git-checkout-index: unable to write file lib/graphincludes/params.pm
> +|fatal: unable to write new index file
> +|stg commit: git-read-tree failed (local changes maybe?)
> +|Committing 4 patches...
> +(luckily nothing was really committed)
But that's the correct behaviour, not to commit anything. The only
problem I see (and I fixed) is the "Committing..." message on stdout
without flushing, causing it to appear afterwards. StGIT cannot know
how much space is needed by GIT to check this beforehand. It simply
exits when a GIT command failed.
Thanks.
--
next prev parent reply other threads:[~2006-12-05 17:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-30 0:23 [PATCH 0/3] Misc stgit patches Yann Dirson
2006-11-30 0:27 ` [PATCH 1/3] Document some current bugs and add to the TODO list Yann Dirson
2006-12-05 17:30 ` Catalin Marinas [this message]
2006-12-05 22:02 ` Yann Dirson
2006-11-30 0:27 ` [PATCH 2/3] More config examples Yann Dirson
2006-11-30 0:27 ` [PATCH 3/3] Create a StgitObject class to factorise code for property handling Yann Dirson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0943d9e0612050930t187e65c4g6a3c44ea1fefc940@mail.gmail.com \
--to=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=ydirson@altern.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).