From: "Catalin Marinas" <catalin.marinas@gmail.com>
To: "Yann Dirson" <ydirson@altern.org>
Cc: git@vger.kernel.org
Subject: Re: [StGIT PATCH 0/2] Fix issues with series deletion
Date: Thu, 7 Jun 2007 22:50:00 +0100 [thread overview]
Message-ID: <b0943d9e0706071450u1587d109x1e592bfa453c0c0@mail.gmail.com> (raw)
In-Reply-To: <20070606205852.7657.69286.stgit@gandelf.nowhere.earth>
On 06/06/07, Yann Dirson <ydirson@altern.org> wrote:
> I am however not happy at all with the way we delete patches and
> series, starting with an existence check and then deleting. If any
> error occurs midway, then we are left with an inconsistent state that
> the user has to cleanup by hand. IMHO, we should have those methods
> be as robust as possible, maybe starting by removing the formatversion
> item, and printing a "cleaning up zombie stack" if does not find it.
> So at least after fixing a "delete" bug, we could rerun the same
> command and get to a sane state again.
This sounds OK for a quick fix. Longer term, I think we should support
some kind of transactions. One idea is to put the StGIT metadata in a
single file (or maybe two if we include the config) that gets checked
in after every operation.
--
Catalin
next prev parent reply other threads:[~2007-06-07 21:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 21:05 [StGIT PATCH 0/2] Fix issues with series deletion Yann Dirson
2007-06-06 21:05 ` [PATCH 1/2] Fix removal of series with non-existant trash dir Yann Dirson
2007-06-06 21:05 ` [PATCH 2/2] Fix removal of series to nuke the formatversion config item Yann Dirson
2007-06-07 21:50 ` Catalin Marinas [this message]
2007-06-09 18:43 ` [StGIT PATCH 0/2] Fix issues with series deletion Yann Dirson
2007-06-12 22:16 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0943d9e0706071450u1587d109x1e592bfa453c0c0@mail.gmail.com \
--to=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=ydirson@altern.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).