From: "Catalin Marinas" <catalin.marinas@gmail.com>
To: "Karl Hasselström" <kha@treskal.com>
Cc: git@vger.kernel.org
Subject: Re: [StGIT PATCH 4/4] Add optional logging of subprocess execution
Date: Mon, 3 Sep 2007 09:34:32 +0100 [thread overview]
Message-ID: <b0943d9e0709030134g6cf9f69ctc688c27dc705df9@mail.gmail.com> (raw)
In-Reply-To: <20070829171621.GA2214@diana.vm.bytemark.co.uk>
On 29/08/07, Karl Hasselström <kha@treskal.com> wrote:
> On 2007-08-29 13:11:02 +0200, Karl Hasselström wrote:
>
> > On 2007-08-29 11:50:11 +0100, Catalin Marinas wrote:
> >
> > > Any objection to calling this variable STGIT_SUBPROCESS_LOG? We
> > > already have STGIT_DEBUG_LEVEL (used in stgit.main). I can do it
> > > in my tree before pushing as I already merged your branches.
> >
> > No, no objection at all. I was simply too lazy to actually check
> > what the existing naming convention was, and misremembered.
>
> You changed it in the code, but forgot to change it in the commit
> message. :-P
I changed it on my office PC and the locale setup breaks your name
encoding :-). I tried to avoid it.
--
Catalin
next prev parent reply other threads:[~2007-09-03 8:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-26 20:33 [StGIT PATCH 0/4] Clean up subprocess calling Karl Hasselström
2007-08-26 20:33 ` [StGIT PATCH 1/4] Refactor output handling to break circular dependency Karl Hasselström
2007-08-26 20:33 ` [StGIT PATCH 2/4] Refactor subprocess creation Karl Hasselström
2007-08-26 20:33 ` [StGIT PATCH 3/4] Assert that the argument to Run is a sequence of strings Karl Hasselström
2007-08-26 20:33 ` [StGIT PATCH 4/4] Add optional logging of subprocess execution Karl Hasselström
2007-08-29 10:50 ` Catalin Marinas
2007-08-29 11:11 ` Karl Hasselström
2007-08-29 17:16 ` Karl Hasselström
2007-09-03 8:34 ` Catalin Marinas [this message]
2007-09-03 8:36 ` Catalin Marinas
2007-09-03 9:04 ` Karl Hasselström
2007-09-03 21:48 ` [StGit PATCH 0/2] Break Python 2.3 compatibility Karl Hasselström
2007-09-03 21:48 ` [StGit PATCH 1/2] Use subprocess.Popen to call git executables Karl Hasselström
2007-09-03 21:48 ` [StGit PATCH 2/2] Use the builtin set() instead of sets.Set() Karl Hasselström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0943d9e0709030134g6cf9f69ctc688c27dc705df9@mail.gmail.com \
--to=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=kha@treskal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).