From: "Catalin Marinas" <catalin.marinas@gmail.com>
To: "Pavel Roskin" <proski@gnu.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Support tags in uncommit - use git_id instead of rev_parse
Date: Sun, 7 Oct 2007 22:06:19 +0100 [thread overview]
Message-ID: <b0943d9e0710071406k38387ee0w961f403c57794159@mail.gmail.com> (raw)
In-Reply-To: <1191447892.31052.5.camel@dv>
On 03/10/2007, Pavel Roskin <proski@gnu.org> wrote:
> On Wed, 2007-10-03 at 21:35 +0100, Catalin Marinas wrote:
>
> > Without this patch, the 'stg uncommit -t patch' fails with 'Unknown
> > revision: patch'. With the patch applied, it still fails but with
> > 'Commit ... does not have exactly one parent'. I don't say that the
> > first one is good but I don't think the latter is clearer. The 'stg
> > uncommit --help' states that the '--to' option takes a commit argument
> > but if one passes a patch name the error message gets pretty
> > confusing.
>
> Actually, 'Commit ... does not have exactly one parent' means that stg
> misinterpreted the patch name as some non-existing hash and started
> iterating back until it hit the first merge.
>
> Perhaps stgit should make sure that the hash is valid before walking the
> commit tree. If it's not, stgit could provide a better message.
OK, I applied your patch but I'll have to look into the error message
to make it more meaningful. Thanks.
--
Catalin
prev parent reply other threads:[~2007-10-07 21:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-30 17:26 [PATCH] Support tags in uncommit - use git_id instead of rev_parse Pavel Roskin
2007-10-01 11:16 ` Karl Hasselström
2007-10-01 22:00 ` Catalin Marinas
2007-10-02 22:03 ` Pavel Roskin
2007-10-03 20:35 ` Catalin Marinas
2007-10-03 21:44 ` Pavel Roskin
2007-10-07 21:06 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0943d9e0710071406k38387ee0w961f403c57794159@mail.gmail.com \
--to=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).