* StGIT: "stg refresh -e/--edit" to refresh patch and edit description no longer works
@ 2007-12-14 14:07 Jakub Narebski
2007-12-14 14:26 ` Catalin Marinas
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Narebski @ 2007-12-14 14:07 UTC (permalink / raw)
To: Catalin Marinas; +Cc: git
The command I used quite often in my StGIT workflow, namely
"stg refresh -e", which used to refresh patch and launch editor to edit
commit (patch) description no longer works in Stacked GIT 0.14.1.
I used it when new (refreshed) changes needed also changes in commit
description (commit message). Now I have to run two commands:
"stg refresh" and "stg edit".
--
Jakub Narebski
Poland
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: StGIT: "stg refresh -e/--edit" to refresh patch and edit description no longer works
2007-12-14 14:07 StGIT: "stg refresh -e/--edit" to refresh patch and edit description no longer works Jakub Narebski
@ 2007-12-14 14:26 ` Catalin Marinas
2007-12-14 16:01 ` Jakub Narebski
0 siblings, 1 reply; 3+ messages in thread
From: Catalin Marinas @ 2007-12-14 14:26 UTC (permalink / raw)
To: Jakub Narebski; +Cc: git
On 14/12/2007, Jakub Narebski <jnareb@gmail.com> wrote:
> The command I used quite often in my StGIT workflow, namely
> "stg refresh -e", which used to refresh patch and launch editor to edit
> commit (patch) description no longer works in Stacked GIT 0.14.1.
>
> I used it when new (refreshed) changes needed also changes in commit
> description (commit message). Now I have to run two commands:
> "stg refresh" and "stg edit".
Well, people complained that 'refresh -e' is misleading and a separate
command is needed. It's not difficult to move the editing
functionality out of stgit.commands.edit and re-add the --edit option
to refresh (while also keeping the separate edit command).
I'm a bit busy with home/family commitments until the new year.
--
Catalin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: StGIT: "stg refresh -e/--edit" to refresh patch and edit description no longer works
2007-12-14 14:26 ` Catalin Marinas
@ 2007-12-14 16:01 ` Jakub Narebski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Narebski @ 2007-12-14 16:01 UTC (permalink / raw)
To: Catalin Marinas; +Cc: git
On Fri, 14 Dec 2007, Catalin Marinas wrote:
> On 14/12/2007, Jakub Narebski <jnareb@gmail.com> wrote:
>>
>> The command I used quite often in my StGIT workflow, namely
>> "stg refresh -e", which used to refresh patch and launch editor to edit
>> commit (patch) description no longer works in Stacked GIT 0.14.1.
>>
>> I used it when new (refreshed) changes needed also changes in commit
>> description (commit message). Now I have to run two commands:
>> "stg refresh" and "stg edit".
>
> Well, people complained that 'refresh -e' is misleading and a separate
> command is needed. It's not difficult to move the editing
> functionality out of stgit.commands.edit and re-add the --edit option
> to refresh (while also keeping the separate edit command).
First, the "misleading" part could be corrected by renaming long option
to --edit-description or --edit-message. Second "stg refresh -e" matches
non-StGIT usage of "git commit --amend"; and it is damn useful to have
it as one command, not two.
> I'm a bit busy with home/family commitments until the new year.
I'll wait. As I am not running StGIT master, but released version,
I would have to waith nevertheless on next release.
TIA
--
Jakub Narebski
Poland
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-12-14 16:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-14 14:07 StGIT: "stg refresh -e/--edit" to refresh patch and edit description no longer works Jakub Narebski
2007-12-14 14:26 ` Catalin Marinas
2007-12-14 16:01 ` Jakub Narebski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).