Re: [STGIT PATCH] replace "git repo-config" usage by "git config"

["Catalin Marinas" <catalin.marinas@gmail.com>]

Hi,

Now I'm back from holiday and I'll start merging patches. Thanks for the fixes.

On 16/01/2008, Jakub Narebski <jnareb@gmail.com> wrote:
> Strange that StGIT didn't abstracted out reading git config, like
> Git.pm and gitweb.perl did.

The initial implementation was to use Python to parse the config file
but it was dropped in favour of the git-config tool. It might be a bit
slower but, at least, we don't need to follow any future syntax
changes.

> BTW. will StGIT be using libgit-thin + PyGit, or is it not ready yet?

The last commit to the libgit project seems to be in August 2007. Is
it still maintained? If GIT will provide a stable API and library, we
might use it but I don't think it would bring a great performance
improvement. Most of the time, in my case, seems to be spent in calls
list git-diff-tree. A few tens of milliseconds avoided by not calling
an external tool would be unnoticed.

-- 
Catalin