From: "Catalin Marinas" <catalin.marinas@gmail.com>
To: "Karl Hasselström" <kha@treskal.com>
Cc: git@vger.kernel.org
Subject: Re: [StGit PATCH] Try the built-in version string before git-describe
Date: Wed, 21 May 2008 15:38:18 +0100 [thread overview]
Message-ID: <b0943d9e0805210738v40b25d54j65e70b3ef2745987@mail.gmail.com> (raw)
In-Reply-To: <20080520213844.13410.32757.stgit@yoghurt>
On 20/05/2008, Karl Hasselström <kha@treskal.com> wrote:
> Try to get the built-in version string first, and fall back to git
> describe if there is no built-in string, instead of the other way
> around. This makes computing the version string much cheaper in the
> common case (whenever StGit is not run directly from a git-controlled
> tree).
>
> In order for this to work when StGit _is_ run directly from a
> git-controlled tree, setup.py has to delete the builtin version file
> once the installation process is over. (Otherwise, the StGit version
> in a git-controlled tree would be frozen at whatever value it happened
> to have when setup.py was last run.)
OK, I thought it was only the ordering change. With this change to
setup.py, I'm OK with the patch. I'll merge your tree tonight.
--
Catalin
next prev parent reply other threads:[~2008-05-21 14:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 1:43 StGit: kha/{safe,experimental} updated Karl Hasselström
2008-05-14 1:44 ` [StGit PATCH 1/2] Import version to a separate namespace Karl Hasselström
2008-05-14 1:47 ` [StGit PATCH 2/2] Better StGit version tracking Karl Hasselström
2008-05-14 1:49 ` [StGit PATCH] Emacs mode: automatically cd up to root of worktree Karl Hasselström
2008-05-14 7:38 ` David Kågedal
2008-05-14 8:13 ` Karl Hasselström
2008-05-14 1:49 ` [StGit PATCH] New command: stg redo Karl Hasselström
2008-05-19 21:21 ` StGit: kha/{safe,experimental} updated Catalin Marinas
2008-05-20 7:04 ` Karl Hasselström
2008-05-20 17:19 ` Catalin Marinas
2008-05-20 21:02 ` Karl Hasselström
2008-05-20 21:39 ` [StGit PATCH] Try the built-in version string before git-describe Karl Hasselström
2008-05-21 14:38 ` Catalin Marinas [this message]
2008-05-21 15:00 ` Karl Hasselström
2008-05-21 14:07 ` StGit: kha/{safe,experimental} updated Catalin Marinas
2008-05-21 14:58 ` Karl Hasselström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0943d9e0805210738v40b25d54j65e70b3ef2745987@mail.gmail.com \
--to=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=kha@treskal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).