From: "Catalin Marinas" <catalin.marinas@gmail.com>
To: "Karl Hasselström" <kha@treskal.com>
Cc: git@vger.kernel.org
Subject: Re: [StGit PATCH 1/2] Convert "stg refresh" to the new infrastructure
Date: Sun, 29 Jun 2008 10:42:32 +0100 [thread overview]
Message-ID: <b0943d9e0806290242q1bc8aa67qb3523221b3db70e2@mail.gmail.com> (raw)
In-Reply-To: <20080625042337.6044.53357.stgit@yoghurt>
2008/6/25 Karl Hasselström <kha@treskal.com>:
> And in the process, make it more powerful: it will now first create a
> temp patch containing the updates, and then try to merge it into the
> patch to be updated. If that patch is applied, this is done by
> popping, pushing, and coalescing; if it is unapplied, it is done with
> an in-index merge.
Does it make sense to refresh an unapplied patch? Maybe adding a new
file to the patch but I don't really see a need for this.
> Also, whenever path limiting is used, we will now use a temporary
> index in order to avoid including all staged updates (since they may
> touch stuff outside the path limiters).
I haven't checked but what is the behaviour in subdirectors? It
currently refreshes everythink unless "." is specified so that it will
only refresh the current subdirectory.
The patch looks fine otherwise.
--
Catalin
next prev parent reply other threads:[~2008-06-29 9:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-25 4:30 [StGit PATCH 1/2] Convert "stg refresh" to the new infrastructure Karl Hasselström
2008-06-25 4:30 ` [StGit PATCH 2/2] New refresh tests Karl Hasselström
2008-06-29 9:42 ` Catalin Marinas [this message]
2008-06-29 10:21 ` [StGit PATCH 1/2] Convert "stg refresh" to the new infrastructure Karl Hasselström
2008-06-29 11:07 ` Catalin Marinas
2008-06-29 13:46 ` Karl Hasselström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0943d9e0806290242q1bc8aa67qb3523221b3db70e2@mail.gmail.com \
--to=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=kha@treskal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).