From: "Catalin Marinas" <catalin.marinas@gmail.com>
To: "Karl Hasselström" <kha@treskal.com>
Cc: git@vger.kernel.org, "Jon Smirl" <jonsmirl@gmail.com>
Subject: Re: [StGit PATCH] Test that we can add a new file to a non-topmost patch with refresh -p
Date: Fri, 25 Jul 2008 22:37:23 +0100 [thread overview]
Message-ID: <b0943d9e0807251437u4c01fb45n98e1b0b29e9c4c78@mail.gmail.com> (raw)
In-Reply-To: <20080722071438.GA16807@diana.vm.bytemark.co.uk>
2008/7/22 Karl Hasselström <kha@treskal.com>:
> On 2008-07-21 23:01:17 +0100, Catalin Marinas wrote:
>
>> I don't think we should spend time on fixing the current code as you
>> already have a new implementation. Maybe we could add a simple test
>> and refuse refreshing other than the topmost patch in case of files
>> added to the index.
>
> Yes, I guess that's OK. Hmm, how do we check that cheaply?
In the stable branch, we already call git.check_status() in the
refresh implementation, so it's pretty cheap to test.
--
Catalin
prev parent reply other threads:[~2008-07-25 21:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 1:29 stgit: bug with refresh and -p Jon Smirl
2008-07-18 8:41 ` Karl Hasselström
2008-07-18 17:03 ` [StGit PATCH] Test that we can add a new file to a non-topmost patch with refresh -p Karl Hasselström
2008-07-18 18:01 ` Karl Hasselström
2008-07-18 17:45 ` Jon Smirl
2008-07-18 19:16 ` Karl Hasselström
2008-07-21 22:01 ` Catalin Marinas
2008-07-22 7:14 ` Karl Hasselström
2008-07-25 21:37 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0943d9e0807251437u4c01fb45n98e1b0b29e9c4c78@mail.gmail.com \
--to=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=jonsmirl@gmail.com \
--cc=kha@treskal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).