git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Catalin Marinas" <catalin.marinas@gmail.com>
To: "Daniel White" <daniel@whitehouse.id.au>
Cc: git@vger.kernel.org
Subject: Re: [StGit PATCH] Fixed default install location
Date: Sun, 27 Jul 2008 09:21:06 +0100	[thread overview]
Message-ID: <b0943d9e0807270121x43b0a454g1042c0cfe650f2c1@mail.gmail.com> (raw)
In-Reply-To: <20080727162750.25b7cdf3@whitehouse.id.au>

2008/7/27 Daniel White <daniel@whitehouse.id.au>:
> "Catalin Marinas" <catalin.marinas@gmail.com> wrote:
>>
>> I also use "python setup.py bdist_rpm" when releasing, I think it will
>> get confused by a different prefix.
>
> Not being familiar with distutils, I didn't even see that use case.

I use "python setup.py bdist_rpm", though passing --prefix would
probably fix it.

> Regardless, the instructions are incorrect and the behaviour surprising.
> When I installed this in a cygwin environment, it went on to clobber
> my system directories.
>
> Would it be more useful to have the Makefile handle the general case and
> setup.py for more specialised cases, such as generating an rpm?

I agree.

> I've thrown some patches together that does some of this.  I can tidy
> these up and put them in a public repository if this sounds like a
> reasonable plan of attack.

Yes, it is. Please base them on my (or Karl's) latest git tree as I
already merged this patch.

Thanks.

-- 
Catalin

  reply	other threads:[~2008-07-27  8:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-24 10:20 [StGit PATCH] Fixed default install location Daniel White
2008-07-24 19:45 ` Karl Hasselström
2008-07-25 21:46 ` Catalin Marinas
2008-07-27  6:27   ` Daniel White
2008-07-27  8:21     ` Catalin Marinas [this message]
2008-07-31  6:29       ` [StGit RFC] Pull request for build/install work Daniel White
2008-08-04 14:38         ` Karl Hasselström
2008-08-05 21:10           ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0943d9e0807270121x43b0a454g1042c0cfe650f2c1@mail.gmail.com \
    --to=catalin.marinas@gmail.com \
    --cc=daniel@whitehouse.id.au \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).