git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [StGIT PATCH] Do not insert an empty line before the diffstat info
@ 2008-07-31 12:50 Samuel Tardieu
  2008-08-04 14:20 ` Karl Hasselström
  0 siblings, 1 reply; 3+ messages in thread
From: Samuel Tardieu @ 2008-07-31 12:50 UTC (permalink / raw)
  To: git; +Cc: Catalin Marinas

To make the format of stg output closer to the plain git one, do
not insert an empty line between the "---" separator and the
diffstat information.

Signed-off-by: Samuel Tardieu <sam@rfc1149.net>
---
 templates/mailattch.tmpl   |    1 -
 templates/patchexport.tmpl |    1 -
 templates/patchmail.tmpl   |    1 -
 3 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/templates/mailattch.tmpl b/templates/mailattch.tmpl
index 430b341..70d2df0 100644
--- a/templates/mailattch.tmpl
+++ b/templates/mailattch.tmpl
@@ -11,7 +11,6 @@ Content-Disposition: inline
 
 %(fromauth)s%(longdescr)s
 ---
-
 %(diffstat)s
 --MIMEBOUNDARY
 Content-Type: text/plain; name=%(patch)s.patch
diff --git a/templates/patchexport.tmpl b/templates/patchexport.tmpl
index e7f3481..11f2075 100644
--- a/templates/patchexport.tmpl
+++ b/templates/patchexport.tmpl
@@ -4,6 +4,5 @@ From: %(authname)s <%(authemail)s>
 
 %(longdescr)s
 ---
-
 %(diffstat)s
 
diff --git a/templates/patchmail.tmpl b/templates/patchmail.tmpl
index f5c35c2..7d4022a 100644
--- a/templates/patchmail.tmpl
+++ b/templates/patchmail.tmpl
@@ -3,6 +3,5 @@ Subject: [%(prefix)sPATCH%(version)s%(number)s] %(shortdescr)s
 
 %(fromauth)s%(longdescr)s
 ---
-
 %(diffstat)s
 %(diff)s

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [StGIT PATCH] Do not insert an empty line before the diffstat info
  2008-07-31 12:50 [StGIT PATCH] Do not insert an empty line before the diffstat info Samuel Tardieu
@ 2008-08-04 14:20 ` Karl Hasselström
  2008-08-05 21:09   ` Catalin Marinas
  0 siblings, 1 reply; 3+ messages in thread
From: Karl Hasselström @ 2008-08-04 14:20 UTC (permalink / raw)
  To: Samuel Tardieu; +Cc: git, Catalin Marinas

On 2008-07-31 14:50:10 +0200, Samuel Tardieu wrote:

> To make the format of stg output closer to the plain git one, do not
> insert an empty line between the "---" separator and the diffstat
> information.

Thanks, will apply. (IMO it's slightly uglier, but it's better to be
consistent. And it does save some space.)

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [StGIT PATCH] Do not insert an empty line before the diffstat info
  2008-08-04 14:20 ` Karl Hasselström
@ 2008-08-05 21:09   ` Catalin Marinas
  0 siblings, 0 replies; 3+ messages in thread
From: Catalin Marinas @ 2008-08-05 21:09 UTC (permalink / raw)
  To: Karl Hasselström; +Cc: Samuel Tardieu, git

2008/8/4 Karl Hasselström <kha@treskal.com>:
> On 2008-07-31 14:50:10 +0200, Samuel Tardieu wrote:
>
>> To make the format of stg output closer to the plain git one, do not
>> insert an empty line between the "---" separator and the diffstat
>> information.
>
> Thanks, will apply. (IMO it's slightly uglier, but it's better to be
> consistent. And it does save some space.)

Without this change, I could easily spot people posting patches with
StGIT rather than Git :-). Anyway, I'm OK with this patch as well.
Thanks.

-- 
Catalin

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-08-05 21:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-31 12:50 [StGIT PATCH] Do not insert an empty line before the diffstat info Samuel Tardieu
2008-08-04 14:20 ` Karl Hasselström
2008-08-05 21:09   ` Catalin Marinas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).