git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Catalin Marinas" <catalin.marinas@gmail.com>
To: "Karl Hasselström" <kha@treskal.com>
Cc: git@vger.kernel.org
Subject: Re: [StGit PATCH] Read several objects at once with git cat-file --batch
Date: Sun, 10 Aug 2008 23:25:08 +0100	[thread overview]
Message-ID: <b0943d9e0808101525w1e6f1e60h162a4b137d6dca6c@mail.gmail.com> (raw)
In-Reply-To: <20080808080614.23424.28169.stgit@yoghurt>

2008/8/8 Karl Hasselström <kha@treskal.com>:
> Instead of spawning a separate cat-file process for every blob and
> commit we want to read. This speeds things up slightly: about 6-8%
> when uncommitting and rebasing 1470 linux-kernel patches (perftest.py
> rebase-newrebase-add-file-linux).

Which version of Git got the --batch option to git-cat-file? It might
be possible that default Git in Debian (testing) or Ubuntu doesn't
have this option. Maybe we could still have the original behaviour as
a fallback.

Otherwise, the patch looks allright. It took me a bit of time to see
why we need the new run_background() function (but in my current Git,
1.5.3.4.206.g58ba4, there wasn't such an option; I had to upgrade).

Thanks.

-- 
Catalin

  reply	other threads:[~2008-08-10 22:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-08  8:27 [StGit] kha/{safe,experimental} updated Karl Hasselström
2008-08-08  8:07 ` [StGit PATCH] Read several objects at once with git cat-file --batch Karl Hasselström
2008-08-10 22:25   ` Catalin Marinas [this message]
2008-08-10 23:58     ` Karl Hasselström
2008-08-13 21:54 ` [StGit] kha/{safe,experimental} updated Catalin Marinas
2008-08-17 20:18   ` Karl Hasselström
2008-08-21 22:16     ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0943d9e0808101525w1e6f1e60h162a4b137d6dca6c@mail.gmail.com \
    --to=catalin.marinas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kha@treskal.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).