From: "Catalin Marinas" <catalin.marinas@gmail.com>
To: "Karl Hasselström" <kha@treskal.com>
Cc: "Erik Sandberg" <mandolaerik@gmail.com>, git@vger.kernel.org
Subject: Re: [StGit PATCH 2/2] Check for top == head at the start of every transaction
Date: Sat, 30 Aug 2008 23:12:06 +0100 [thread overview]
Message-ID: <b0943d9e0808301512g6d0a37f7o59e6392687cbafcf@mail.gmail.com> (raw)
In-Reply-To: <20080827220657.3607.88972.stgit@yoghurt>
2008/8/27 Karl Hasselström <kha@treskal.com>:
> We used to check it in the run() method, but that's sometimes too
> late: for example, it causes stg coalesce to ask for a commit message
> _before_ the check, resulting in a lost commit message if the check
> fails.
>
> As before, the check can be disabled for the few commands that need
> it.
Looks fine. Thanks.
--
Catalin
prev parent reply other threads:[~2008-08-30 22:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-27 22:06 [StGit PATCH 0/2] Fix bug 12204 Karl Hasselström
2008-08-27 22:06 ` [StGit PATCH 1/2] Test that stg coalesce handles head != top gracefully Karl Hasselström
2008-08-27 22:06 ` [StGit PATCH 2/2] Check for top == head at the start of every transaction Karl Hasselström
2008-08-30 22:12 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0943d9e0808301512g6d0a37f7o59e6392687cbafcf@mail.gmail.com \
--to=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=kha@treskal.com \
--cc=mandolaerik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).